[Dashboard][Lens] 8px padding added to some panels
#201829
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Embeddables
Relating to the Embeddable system
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
loe:small
Small Level of Effort
regression
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Comments
Heenawter
added
bug
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Heenawter
added
impact:critical
1 task
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 29, 2024
## Summary Fixes elastic#201829 This PR fixes a regression introduced with elastic#178965 where specific visualization display options were ignored in the embeddable context. Additional tests have been added to avoid further regressions in the future. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit fd589b8)
kibanamachine
added a commit
that referenced
this issue
Nov 29, 2024
…202294) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Fix display options regressions (#201998)](#201998) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T12:42:09Z","message":"[Lens][Embeddable] Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes #201829\r\n\r\nThis PR fixes a regression introduced with #178965 where specific\r\nvisualization display options were ignored in the embeddable context.\r\nAdditional tests have been added to avoid further regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor"],"title":"[Lens][Embeddable] Fix display options regressions","number":201998,"url":"https://github.com/elastic/kibana/pull/201998","mergeCommit":{"message":"[Lens][Embeddable] Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes #201829\r\n\r\nThis PR fixes a regression introduced with #178965 where specific\r\nvisualization display options were ignored in the embeddable context.\r\nAdditional tests have been added to avoid further regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201998","number":201998,"mergeCommit":{"message":"[Lens][Embeddable] Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes #201829\r\n\r\nThis PR fixes a regression introduced with #178965 where specific\r\nvisualization display options were ignored in the embeddable context.\r\nAdditional tests have been added to avoid further regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf"}}]}] BACKPORT--> Co-authored-by: Marco Liberati <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 12, 2024
## Summary Fixes elastic#201829 This PR fixes a regression introduced with elastic#178965 where specific visualization display options were ignored in the embeddable context. Additional tests have been added to avoid further regressions in the future. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
After #186642 was merged, extra padding was added to some visualizations:
This is definitely coming from the embeddable and not the dashboard styles, because it's attached to the component with the
.expExpressionRenderer__expressionclass :)The text was updated successfully, but these errors were encountered: