Refactor lens embeddable #178965
Closed
Refactor lens embeddable #178965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dej611
added a commit
that referenced
this pull request
Nov 29, 2024
## Summary Fixes #201829 This PR fixes a regression introduced with #178965 where specific visualization display options were ignored in the embeddable context. Additional tests have been added to avoid further regressions in the future. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 29, 2024
## Summary Fixes elastic#201829 This PR fixes a regression introduced with elastic#178965 where specific visualization display options were ignored in the embeddable context. Additional tests have been added to avoid further regressions in the future. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit fd589b8)
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2024
…202294) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Fix display options regressions (#201998)](#201998) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T12:42:09Z","message":"[Lens][Embeddable] Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes #201829\r\n\r\nThis PR fixes a regression introduced with #178965 where specific\r\nvisualization display options were ignored in the embeddable context.\r\nAdditional tests have been added to avoid further regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor"],"title":"[Lens][Embeddable] Fix display options regressions","number":201998,"url":"https://github.com/elastic/kibana/pull/201998","mergeCommit":{"message":"[Lens][Embeddable] Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes #201829\r\n\r\nThis PR fixes a regression introduced with #178965 where specific\r\nvisualization display options were ignored in the embeddable context.\r\nAdditional tests have been added to avoid further regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201998","number":201998,"mergeCommit":{"message":"[Lens][Embeddable] Fix display options regressions (#201998)\n\n## Summary\r\n\r\nFixes #201829\r\n\r\nThis PR fixes a regression introduced with #178965 where specific\r\nvisualization display options were ignored in the embeddable context.\r\nAdditional tests have been added to avoid further regressions in the\r\nfuture.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fd589b844c133284a504bad10c0d04288723badf"}}]}] BACKPORT--> Co-authored-by: Marco Liberati <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Fixes elastic#201829 This PR fixes a regression introduced with elastic#178965 where specific visualization display options were ignored in the embeddable context. Additional tests have been added to avoid further regressions in the future. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO