Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix the Trained Models table expanded row refresh #198149

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[ML] Fix the Trained Models table expanded row refresh #198149

merged 2 commits into from
Oct 30, 2024

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Oct 29, 2024 •
edited by kibanamachine
Loading

Summary

Fixes a regression introduced in #194614, where the content of expanded rows in the Trained Model table stopped being updated on refresh.

@darnautov darnautov requested a review from a team as a code owner October 29, 2024 11:33
@darnautov darnautov self-assigned this Oct 29, 2024
@darnautov darnautov added Team:ML Team label for ML (also use :ml) v8.16.0 backport:version Backport to applied version labels labels Oct 29, 2024
@darnautov darnautov requested a review from rbrtj October 29, 2024 11:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

rbrtj
rbrtj approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@rbrtj rbrtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and worked fine 👍

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.5MB 4.5MB +134.0B

History

cc @darnautov

@peteharverson peteharverson requested review from jgowdyelastic and removed request for peteharverson October 30, 2024 14:24
jgowdyelastic
jgowdyelastic approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@darnautov darnautov merged commit 7e05d5c into elastic:main Oct 30, 2024
21 checks passed
@darnautov darnautov deleted the ml-trained-models-fix-expanded-row branch October 30, 2024 15:34
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16

https://github.com/elastic/kibana/actions/runs/11596565652

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2024
@darnautov
[ML] Fix the Trained Models table expanded row refresh (elastic#198149)
32b79af 
## Summary

Fixes a regression introduced in
elastic#194614, where the content of
expanded rows in the Trained Model table stopped being updated on
refresh.

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 7e05d5c)
@kibanamachine kibanamachine mentioned this pull request Oct 30, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@jgowdyelastic jgowdyelastic mentioned this pull request Oct 30, 2024
Closed
kibanamachine added a commit that referenced this pull request Oct 30, 2024
@kibanamachine @darnautov
[8.16] [ML] Fix the Trained Models table expanded row refresh (#198149)…
8d35157 
… (#198391)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[ML] Fix the Trained Models table expanded row refresh
(#198149)](#198149)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T15:34:29Z","message":"[ML]
Fix the Trained Models table expanded row refresh (#198149)\n\n##
Summary\r\n\r\nFixes a regression introduced
in\r\nhttps://github.com//pull/194614/, where the content
of\r\nexpanded rows in the Trained Model table stopped being updated
on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:3rd
Party Models","Team:ML","v8.16.0","backport:version"],"title":"[ML] Fix
the Trained Models table expanded row
refresh","number":198149,"url":"https://github.com/elastic/kibana/pull/198149","mergeCommit":{"message":"[ML]
Fix the Trained Models table expanded row refresh (#198149)\n\n##
Summary\r\n\r\nFixes a regression introduced
in\r\nhttps://github.com//pull/194614/, where the content
of\r\nexpanded rows in the Trained Model table stopped being updated
on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198149","number":198149,"mergeCommit":{"message":"[ML]
Fix the Trained Models table expanded row refresh (#198149)\n\n##
Summary\r\n\r\nFixes a regression introduced
in\r\nhttps://github.com//pull/194614/, where the content
of\r\nexpanded rows in the Trained Model table stopped being updated
on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
@darnautov darnautov added v8.17.0 and removed backport:version Backport to applied version labels labels Oct 31, 2024
@darnautov darnautov added the backport:version Backport to applied version labels label Oct 31, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11609519297

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 31, 2024
@darnautov
[ML] Fix the Trained Models table expanded row refresh (elastic#198149)
27f9436 
## Summary

Fixes a regression introduced in
elastic#194614, where the content of
expanded rows in the Trained Model table stopped being updated on
refresh.

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 7e05d5c)
@kibanamachine kibanamachine mentioned this pull request Oct 31, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.16 Cherrypick failed because the selected commit (7e05d5c) is empty. It looks like the commit was already backported in #198391
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 198149

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 31, 2024
@kibanamachine @darnautov
[8.x] [ML] Fix the Trained Models table expanded row refresh (#198149) (
89e94b3 
#198484)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Fix the Trained Models table expanded row refresh
(#198149)](#198149)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T15:34:29Z","message":"[ML]
Fix the Trained Models table expanded row refresh (#198149)\n\n##
Summary\r\n\r\nFixes a regression introduced
in\r\nhttps://github.com//pull/194614/, where the content
of\r\nexpanded rows in the Trained Model table stopped being updated
on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:3rd
Party
Models","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
Fix the Trained Models table expanded row
refresh","number":198149,"url":"https://github.com/elastic/kibana/pull/198149","mergeCommit":{"message":"[ML]
Fix the Trained Models table expanded row refresh (#198149)\n\n##
Summary\r\n\r\nFixes a regression introduced
in\r\nhttps://github.com//pull/194614/, where the content
of\r\nexpanded rows in the Trained Model table stopped being updated
on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198149","number":198149,"mergeCommit":{"message":"[ML]
Fix the Trained Models table expanded row refresh (#198149)\n\n##
Summary\r\n\r\nFixes a regression introduced
in\r\nhttps://github.com//pull/194614/, where the content
of\r\nexpanded rows in the Trained Model table stopped being updated
on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198391","number":198391,"state":"MERGED","mergeCommit":{"sha":"8d3515762850843c99545881d5b43b024b5a8bd2","message":"[8.16]
[ML] Fix the Trained Models table expanded row refresh (#198149)
(#198391)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.16`:\n- [[ML] Fix the Trained Models table expanded row
refresh\n(#198149)](https://github.com/elastic/kibana/pull/198149)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Dima\nArnautov\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-30T15:34:29Z\",\"message\":\"[ML]\nFix
the Trained Models table expanded row refresh
(#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression
introduced\nin\\r\\nhttps://github.com//pull/194614/,
where the content\nof\\r\\nexpanded rows in the Trained Model table
stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by:
Elastic
Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\":ml\",\"v9.0.0\",\"Feature:3rd\nParty
Models\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]
Fix\nthe Trained Models table expanded
row\nrefresh\",\"number\":198149,\"url\":\"https://github.com/elastic/kibana/pull/198149\",\"mergeCommit\":{\"message\":\"[ML]\nFix
the Trained Models table expanded row refresh
(#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression
introduced\nin\\r\\nhttps://github.com//pull/194614/,
where the content\nof\\r\\nexpanded rows in the Trained Model table
stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by:
Elastic
Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198149\",\"number\":198149,\"mergeCommit\":{\"message\":\"[ML]\nFix
the Trained Models table expanded row refresh
(#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression
introduced\nin\\r\\nhttps://github.com//pull/194614/,
where the content\nof\\r\\nexpanded rows in the Trained Model table
stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by:
Elastic
Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Dima Arnautov
<[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbrtj rbrtj rbrtj approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@darnautov darnautov

Labels
backport:version Backport to applied version labels Feature:3rd Party Models ML 3rd party models :ml release_note:fix Team:ML Team label for ML (also use :ml) v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @kibanamachine @jgowdyelastic @rbrtj