[ML] Updates for Trained Models table layout and model states #194614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:enhancement
:ml
v9.0.0
Team:ML
|
Pinging @elastic/ml-ui (:ml) |
| 'data-test-subj': 'mlModelsTableColumnCreatedAt', | ||
| }, | ||
| { | ||
| width: '15%', | ||
| name: i18n.translate('xpack.ml.trainedModels.modelsList.actionsHeader', { | ||
| defaultMessage: 'Actions', |
There was a problem hiding this comment.
Is there an easy way to pick which icons are displayed when there are two actions displayed in the column? The current setup shows the 'Test' action, but now I see the Data Drift action for DFA models. 'Test' is probably more commonly used. If not easy, leave it as it is.
There was a problem hiding this comment.
I made the Test action primary in 6fb1c5e
peteharverson
approved these changes
Oct 8, 2024
walterra
approved these changes
Oct 8, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Async chunks
History
cc @darnautov |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11251245135 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…c#194614) ## Summary - Updates Trained Models table layout - Adds the E5 model disclaimer - Removes redundant success toasts about model download, deletion, and start of a deployment <img width="1504" alt="image" src="https://github.com/user-attachments/assets/e151afca-a9bf-4b4e-9d8c-a87c86c83ef9"> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 88cf632)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
darnautov
added a commit
that referenced
this pull request
Oct 9, 2024
## Summary Removes assertions for success toast messages that were deleted in #194614 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
## Summary Removes assertions for success toast messages that were deleted in elastic#194614 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a406acb)
2 tasks
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…5587) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix assertion in the Trained Model UI tests (#195566)](#195566) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T12:24:31Z","message":"[ML] Fix assertion in the Trained Model UI tests (#195566)\n\n## Summary\r\n\r\nRemoves assertions for success toast messages that were deleted in\r\nhttps://github.com//pull/194614\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a406acba31ed05588ae21eed5d380722e32fbbb0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML] Fix assertion in the Trained Model UI tests ","number":195566,"url":"https://github.com/elastic/kibana/pull/195566","mergeCommit":{"message":"[ML] Fix assertion in the Trained Model UI tests (#195566)\n\n## Summary\r\n\r\nRemoves assertions for success toast messages that were deleted in\r\nhttps://github.com//pull/194614\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a406acba31ed05588ae21eed5d380722e32fbbb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195566","number":195566,"mergeCommit":{"message":"[ML] Fix assertion in the Trained Model UI tests (#195566)\n\n## Summary\r\n\r\nRemoves assertions for success toast messages that were deleted in\r\nhttps://github.com//pull/194614\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a406acba31ed05588ae21eed5d380722e32fbbb0"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
darnautov
pushed a commit
that referenced
this pull request
Oct 9, 2024
darnautov
added a commit
that referenced
this pull request
Oct 30, 2024
## Summary Fixes a regression introduced in #194614, where the content of expanded rows in the Trained Model table stopped being updated on refresh. Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2024
## Summary Fixes a regression introduced in elastic#194614, where the content of expanded rows in the Trained Model table stopped being updated on refresh. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 7e05d5c)
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
… (#198391) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] Fix the Trained Models table expanded row refresh (#198149)](#198149) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T15:34:29Z","message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:3rd Party Models","Team:ML","v8.16.0","backport:version"],"title":"[ML] Fix the Trained Models table expanded row refresh","number":198149,"url":"https://github.com/elastic/kibana/pull/198149","mergeCommit":{"message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198149","number":198149,"mergeCommit":{"message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
## Summary Fixes a regression introduced in elastic#194614, where the content of expanded rows in the Trained Model table stopped being updated on refresh. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 7e05d5c)
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
#198484) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix the Trained Models table expanded row refresh (#198149)](#198149) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T15:34:29Z","message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:3rd Party Models","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Fix the Trained Models table expanded row refresh","number":198149,"url":"https://github.com/elastic/kibana/pull/198149","mergeCommit":{"message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198149","number":198149,"mergeCommit":{"message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198391","number":198391,"state":"MERGED","mergeCommit":{"sha":"8d3515762850843c99545881d5b43b024b5a8bd2","message":"[8.16] [ML] Fix the Trained Models table expanded row refresh (#198149) (#198391)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[ML] Fix the Trained Models table expanded row refresh\n(#198149)](https://github.com/elastic/kibana/pull/198149)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Dima\nArnautov\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-30T15:34:29Z\",\"message\":\"[ML]\nFix the Trained Models table expanded row refresh (#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression introduced\nin\\r\\nhttps://github.com//pull/194614/, where the content\nof\\r\\nexpanded rows in the Trained Model table stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\":ml\",\"v9.0.0\",\"Feature:3rd\nParty Models\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML] Fix\nthe Trained Models table expanded row\nrefresh\",\"number\":198149,\"url\":\"https://github.com/elastic/kibana/pull/198149\",\"mergeCommit\":{\"message\":\"[ML]\nFix the Trained Models table expanded row refresh (#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression introduced\nin\\r\\nhttps://github.com//pull/194614/, where the content\nof\\r\\nexpanded rows in the Trained Model table stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198149\",\"number\":198149,\"mergeCommit\":{\"message\":\"[ML]\nFix the Trained Models table expanded row refresh (#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression introduced\nin\\r\\nhttps://github.com//pull/194614/, where the content\nof\\r\\nexpanded rows in the Trained Model table stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Dima Arnautov <[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist