-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Deleting trained model while expanded row is open causes page crash. #198408
Comments
jgowdyelastic
added
:ml
bug
Fixes for quality problems that affect the customer experience
v8.16.0
v8.17.0
v9.0.0
labels
Oct 30, 2024
Pinging @elastic/ml-ui (:ml) |
1 task
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 31, 2024
## Summary Fixes elastic#198408. Fixes trained model item deletion with expanded row. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit bd21496)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 31, 2024
## Summary Fixes elastic#198408. Fixes trained model item deletion with expanded row. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit bd21496)
kibanamachine
added a commit
that referenced
this issue
Oct 31, 2024
…98568) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix Trained model deletion with expanded row (#198530)](#198530) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T15:33:17Z","message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Fix Trained model deletion with expanded row","number":198530,"url":"https://github.com/elastic/kibana/pull/198530","mergeCommit":{"message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198530","number":198530,"mergeCommit":{"message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
kibanamachine
added a commit
that referenced
this issue
Oct 31, 2024
…198567) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] Fix Trained model deletion with expanded row (#198530)](#198530) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T15:33:17Z","message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Fix Trained model deletion with expanded row","number":198530,"url":"https://github.com/elastic/kibana/pull/198530","mergeCommit":{"message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198530","number":198530,"mergeCommit":{"message":"[ML] Fix Trained model deletion with expanded row (#198530)\n\n## Summary\r\n\r\nFixes #198408.\r\n\r\nFixes trained model item deletion with expanded row.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"bd21496b3c0af2167918bd385bd259b05c8e765d"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
nreese
pushed a commit
to nreese/kibana
that referenced
this issue
Nov 1, 2024
## Summary Fixes elastic#198408. Fixes trained model item deletion with expanded row. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I suspect this is related to the recent expanded row update PR as previously performing this action would cause the row to lock open, but not crash.
4D9FEA9B-0558-49C4-A7C0-E402A460358E-57047-00001BA451CFB0D0.mp4
The text was updated successfully, but these errors were encountered: