[ES|QL] Hide field statistics tab and Dashboard when ES|QL is in use, disable Index data visualizer for MATCH and QSRT functions

[qn895]

Summary

Part of #196995. This PR disables field statistics tab and Dashboard embeddable when ES|QL is in used. In Index data visualizer, it is disabled when MATCH & QSRT is in used.

1. Hide Discover's Field statistics tab:

Screen.Recording.2024-11-05.at.09.44.03.mov

2. ML's Index data visualizer:

Message will popup and user will not be allowed to run query if it contains MATCH or QRST

3. Dashboard:

Hide the option to add panel and show unavailable for existing ES|QL panel

For existing dashboards and saved searches with ES|QL field statistics:

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Flaky Test Runner was used on any tests changed
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This will appear in the Release Notes and follow the guidelines

[jughosta]

QQ: should we also skip the request to ES in this case?

[qn895]

Yes! Definitely. Thanks for catching that. I'll make the change.

[jughosta]

Thanks!

[stratoula]

Quynh lets add this check to the esql-utils, these fucntions have a lot of limitations so it will get in handy for other consumers too.

[qn895]

Added a util here 38d47b9 (#197538). Open to suggestion what kind of utlity/API you would like us to expose.

[stratoula]

@ryankeairns @MichaelMarcialis can you take a look here? How do we feel about this? I think the dashboard panel warning could use some love to make it more consistent with the rest of the panels maybe?

[qn895]

/ci

[jughosta]

This file is quite large already. Let's move this logic to fetchAndCalculateFieldStats handler in

kibana/packages/kbn-unified-field-list/src/services/field_stats_text_based/field_stats_utils_text_based.ts

Line 56 in b628770

export async function fetchAndCalculateFieldStats(params: FetchAndCalculateFieldStatsParams) {

[qn895]

I ended up refactoring it to loadFieldStatsTextBased instead here 4215c9c (#197538)

[jughosta]

This would not work for all translations. I think we better define 2 full messages (without concatenation).

[qn895]

Updated here b2b7222 (#197538)

[stratoula]

I think the only thing I find a bit odd is the dashbopard panel. It seems as it needs a space or something? @MichaelMarcialis wdyt?

I see there is an open discussion on the field stats on ES|QL.

[stratoula]

Can we add some unit tests?

[qn895]

Updated here b2b7222 (#197538)

[ryankeairns]

I think the only thing I find a bit odd is the dashbopard panel. It seems as it needs a space or something? @MichaelMarcialis wdyt?

img
I see there is an open discussion on the field stats on ES|QL.

@stratoula @MichaelMarcialis what do you think of these options?

Note: In this scenario, that space below the editor is otherwise unused. At first glance of this issue, I presumed it the callout may be filling space where content would otherwise render. That is not the case which makes this current placement rather unexpected, imo.

Two alternatives

1. In the create state, there is a blue info callout already in place. We could follow suit and move this yellow warning callout up there too. The downsides - having done this locally - is that this causes the editor to jump down the second it realizes you're typing a MATCH command. It's not terrible but is jarring. Also, the stacked callouts is kind of a lot, visually. In the edit state, you only see the single yellow callout, but the jump effect still happens.

2. As an alternative, we could just do away with the yellow callout and place an EuiIconTip alongside the already-disabled button state (it's disabled as a result of this situation, so it makes sense, contextually, to clarify why the button is disabled).

[stratoula]

@ryankeairns if we keep the yellow callout visible all the time? If someone types match / qstr then we disable the button, and display the warning. So actually do both.

[MichaelMarcialis]

what do you think of these options?

@ryankeairns: I like option 2, to avoid the stacking callouts.

[stratoula]

It is hidden, tested again 👍 Thanx Quyhn for your patience with this :)

[jughosta]

Agree with Stratoula. Almost there!

[jughosta]

Suggested change

	if (isEsql) {
	return (
	<EuiEmptyPrompt
	icon={<EuiIcon size="l" type="warning" color="warning" />}
	color="plain"
	paddingSize="m"
	css={css`
	margin: ${euiTheme.size.xl} auto;
	`}
	title={
	<h2 data-test-subj="fieldStatsUnavailableCalloutTitle">
	<FormattedMessage
	id="discover.fieldStatsNotAvailableForESQLCalloutTitle"
	defaultMessage="Field statistics are not available for ES|QL queries"
	/>
	</h2>
	}
	titleSize="xs"
	hasBorder
	/>
	);
	}

Can we move this message from FieldStatisticsTab and SearchEmbeddablFieldStatsTableComponent to FieldStatisticsTable to avoid duplications?

Also, would be great to have the same styles and copy for a search embeddable panel and a field stats panel. Currently it looks like this:

[qn895]

Updated here dc99c68 (#197538)

[jughosta]

Suggested change

getReasonIfFieldStatsUnavailableForQuery: jest.fn().mockReturnValue(undefined),

Can be reverted now, right?

[qn895]

Reverted here eabc053 (#197538)

[jughosta]

instead of auto-directing

Is not what we do on L109-L113?

[qn895]

For the most part yes if user opening a bookmarked link from the browser with Field stats previously set, it will redirect automatically. But when opening a saved search that a user previously saved, it doesn't redirect automatically. I think it makes sense because if a user is expecting field statistics from a saved search and the page is auto directing without any messaging that would be confusing.

Screen.Recording.2024-11-11.at.09.28.04.mov

Screen.Recording.2024-11-11.at.09.27.48.mov

[jughosta]

LGTM 👍
Thanks, Quynh!

[qn895]

@elasticmachine merge upstream

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 2f2b2fb

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
cloudSecurityPosture	661	662	+1
dashboard	678	679	+1
data	516	517	+1
dataVisualizer	734	735	+1
discover	971	972	+1
esql	91	92	+1
esqlDataGrid	369	370	+1
eventAnnotationListing	584	585	+1
infra	1525	1526	+1
investigateApp	582	583	+1
lens	1470	1471	+1
lists	341	342	+1
logsExplorer	569	570	+1
logsShared	700	701	+1
maps	1243	1244	+1
ml	2138	2139	+1
observability	1068	1069	+1
observabilityAIAssistantApp	384	385	+1
securitySolution	6196	6197	+1
slo	854	855	+1
stackAlerts	161	162	+1
unifiedHistogram	193	194	+1
unifiedSearch	375	376	+1
total			+23

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/esql-utils	73	74	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
aiops	581.0KB	581.1KB	+107.0B
apm	3.4MB	3.4MB	+34.0B
dataVisualizer	632.5KB	615.1KB	-17.4KB
discover	806.2KB	806.8KB	+680.0B
lens	1.5MB	1.5MB	+34.0B
ml	4.7MB	4.7MB	+104.0B
securitySolution	13.4MB	13.4MB	+34.0B
slo	852.7KB	852.7KB	+34.0B
transform	473.0KB	473.1KB	+104.0B
total			-16.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
dataVisualizer	27.1KB	24.5KB	-2.7KB

Unknown metric groups

API count

id	before	after	diff
@kbn/esql-utils	81	83	+2

async chunk count

id	before	after	diff
dataVisualizer	24	17	-7

ESLint disabled line counts

id	before	after	diff
dataVisualizer	77	78	+1

Total ESLint disabled count

id	before	after	diff
dataVisualizer	78	79	+1

History

• 💚 Build #250018 succeeded 5cf259a
• 💔 Build #249067 failed 5ccbdf7
• 💔 Build #249030 failed 34379b7
• 💔 Build #248975 failed 1fd7119
• 💚 Build #248550 succeeded bafff15
• 💔 Build #248333 failed 7ea2efb

cc @qn895

[kibanamachine]

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11803608063

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation