Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Set explicit access options for APM public APIs #197435

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[APM] Set explicit access options for APM public APIs #197435

merged 4 commits into from
Oct 24, 2024

Conversation

miloszmarcinkowski
Copy link
Contributor

@miloszmarcinkowski miloszmarcinkowski commented Oct 23, 2024 •
edited
Loading

Summary

Closes #192473
Part of #186781

Set explicit access option to public for APM public APIs.

List of affected APIs:

POST /api/apm/agent_keys 2023-10-31
GET /api/apm/services/{serviceName}/annotation/search 2023-10-31
POST /api/apm/services/{serviceName}/annotation 2023-10-31
GET /api/apm/settings/agent-configuration 2023-10-31
DELETE /api/apm/settings/agent-configuration 2023-10-31
PUT /api/apm/settings/agent-configuration 2023-10-31
POST /api/apm/settings/agent-configuration/search 2023-10-31
GET /api/apm/sourcemaps 2023-10-31
POST /api/apm/sourcemaps 2023-10-31
DELETE /api/apm/sourcemaps/{id} 2023-10-31
GET /api/apm/settings/agent-configuration/view 2023-10-31
GET /api/apm/settings/agent-configuration/environments 2023-10-31
GET /api/apm/settings/agent-configuration/agent_name 2023-10-31
POST /api/apm/fleet/apm_server_schema 2023-10-31

@miloszmarcinkowski miloszmarcinkowski requested a review from a team as a code owner October 23, 2024 13:27
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@miloszmarcinkowski miloszmarcinkowski marked this pull request as draft October 23, 2024 13:27
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@miloszmarcinkowski miloszmarcinkowski changed the title 192473 confirm correct api access for v9 [APM] Set explicit access options for APM public APIs Oct 23, 2024
@miloszmarcinkowski miloszmarcinkowski added v9.0.0 apm backport:skip This commit does not require backporting labels Oct 23, 2024
@miloszmarcinkowski miloszmarcinkowski force-pushed the 192473-confirm-correct-api-access-for-v9 branch from a69bb4a to c9ba1a5 Compare October 23, 2024 15:49
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 24, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 9a6f478
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197435-9a6f4787c7d1

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / EditableMarkdown Save button click calls onSaveContent and onChangeEditable when text area value changed
  • [job] [logs] Jest Tests #15 / useSetupTechnology should update new agent policy and selected policy tab when setup technology is agent-based

Metrics [docs]

✅ unchanged

History

@miloszmarcinkowski miloszmarcinkowski marked this pull request as ready for review October 24, 2024 09:47
@miloszmarcinkowski miloszmarcinkowski added the release_note:skip Skip the PR/issue when compiling release notes label Oct 24, 2024
MiriamAparicio
MiriamAparicio approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rmyz
rmyz approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@miloszmarcinkowski miloszmarcinkowski merged commit db0a898 into elastic:main Oct 24, 2024
29 checks passed
@miloszmarcinkowski miloszmarcinkowski mentioned this pull request Nov 19, 2024
Closed
miloszmarcinkowski added a commit to miloszmarcinkowski/kibana that referenced this pull request Nov 19, 2024
@miloszmarcinkowski
Revert "[APM] Set explicit access options for APM public APIs (elasti…
a6a1bc3 
…c#197435)"

This reverts commit db0a898.
@miloszmarcinkowski miloszmarcinkowski mentioned this pull request Nov 19, 2024
Merged
miloszmarcinkowski added a commit that referenced this pull request Nov 19, 2024
@miloszmarcinkowski
Revert "[APM] Set explicit access options for APM public APIs (#197435)…
236586c 
…" (#200750)

closes #200742

This PR reverts changes introduced in
[PR](#197435) to avoid duplicating
logic.
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@miloszmarcinkowski @paulinashakirova
Revert "[APM] Set explicit access options for APM public APIs (elasti…
94006a4 
…c#197435)" (elastic#200750)

closes elastic#200742

This PR reverts changes introduced in
[PR](elastic#197435) to avoid duplicating
logic.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@miloszmarcinkowski @CAWilson94
Revert "[APM] Set explicit access options for APM public APIs (elasti…
d7d8f8d 
…c#197435)" (elastic#200750)

closes elastic#200742

This PR reverts changes introduced in
[PR](elastic#197435) to avoid duplicating
logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@rmyz rmyz rmyz approved these changes

Assignees
No one assigned
Labels
apm backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm correct API access for v9
4 participants
@miloszmarcinkowski @elasticmachine @rmyz @MiriamAparicio