Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Remove explicit API access definition #200742

Closed
miloszmarcinkowski opened this issue Nov 19, 2024 · 1 comment · Fixed by #200750
Closed

[APM] Remove explicit API access definition #200742

miloszmarcinkowski opened this issue Nov 19, 2024 · 1 comment · Fixed by #200750
Assignees
@miloszmarcinkowski
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@miloszmarcinkowski
Copy link
Contributor

miloszmarcinkowski commented Nov 19, 2024 •
edited
Loading

part of #192473

Summary

We found out redundancy in setting up explicit access option in public APM APIs. This is being handled a top-level during routes registration.

kibana/x-pack/plugins/observability_solution/apm/server/routes/apm_routes/register_apm_server_routes.ts

Line 232 in 0caa6cd

access: pathname.includes('/internal/apm') ? 'internal' : 'public',

AC:

  • revert redundant explicit access option in APIs introduced in this PR
@miloszmarcinkowski miloszmarcinkowski self-assigned this Nov 19, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 19, 2024
@miloszmarcinkowski miloszmarcinkowski added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team and removed needs-team Issues missing a team label labels Nov 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@miloszmarcinkowski miloszmarcinkowski added the technical debt Improvement of the software architecture and operational architecture label Nov 19, 2024
@miloszmarcinkowski miloszmarcinkowski mentioned this issue Nov 19, 2024
Merged
@miloszmarcinkowski miloszmarcinkowski linked a pull request Nov 19, 2024 that will close this issue
Revert "[APM] Set explicit access options for APM public APIs (#197435)" #200750
Merged
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@miloszmarcinkowski @paulinashakirova
Revert "[APM] Set explicit access options for APM public APIs (elasti…
94006a4 
…c#197435)" (elastic#200750)

closes elastic#200742

This PR reverts changes introduced in
[PR](elastic#197435) to avoid duplicating
logic.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@miloszmarcinkowski @CAWilson94
Revert "[APM] Set explicit access options for APM public APIs (elasti…
d7d8f8d 
…c#197435)" (elastic#200750)

closes elastic#200742

This PR reverts changes introduced in
[PR](elastic#197435) to avoid duplicating
logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miloszmarcinkowski miloszmarcinkowski

Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "[APM] Set explicit access options for APM public APIs (#197435)" miloszmarcinkowski/kibana
2 participants
@elasticmachine @miloszmarcinkowski