Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm correct API access for v9 #192473

Closed
kpatticha opened this issue Sep 10, 2024 · 1 comment · Fixed by #197435
Closed

Confirm correct API access for v9 #192473

kpatticha opened this issue Sep 10, 2024 · 1 comment · Fixed by #197435
Assignees
@miloszmarcinkowski
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@kpatticha
Copy link
Contributor

API route access is changing in V9.

  • A route must be tagged with access:{valid_access_string} to specify its intended access
  • Any route that isn't tagged with the access: tag will be PRIVATE by default

Acceptance criteria

  • We need to confirm that our APIs have the intended access configuration
  • Make adjustments if needed (APM has some public APIs)

example work: https://github.com/elastic/kibana/pull/186882/files
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 10, 2024
@kpatticha kpatticha added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team and removed needs-team Issues missing a team label labels Sep 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith smith added the technical debt Improvement of the software architecture and operational architecture label Sep 10, 2024
@miloszmarcinkowski miloszmarcinkowski self-assigned this Oct 23, 2024
@miloszmarcinkowski miloszmarcinkowski mentioned this issue Oct 23, 2024
Merged
miloszmarcinkowski added a commit that referenced this issue Oct 24, 2024
@miloszmarcinkowski
[APM] Set explicit access options for APM public APIs (#197435)
db0a898 
## Summary

Closes #192473 
Part of #186781

Set explicit `access` option to `public` for APM public APIs.

List of affected APIs:
```
POST /api/apm/agent_keys 2023-10-31
GET /api/apm/services/{serviceName}/annotation/search 2023-10-31
POST /api/apm/services/{serviceName}/annotation 2023-10-31
GET /api/apm/settings/agent-configuration 2023-10-31
DELETE /api/apm/settings/agent-configuration 2023-10-31
PUT /api/apm/settings/agent-configuration 2023-10-31
POST /api/apm/settings/agent-configuration/search 2023-10-31
GET /api/apm/sourcemaps 2023-10-31
POST /api/apm/sourcemaps 2023-10-31
DELETE /api/apm/sourcemaps/{id} 2023-10-31
GET /api/apm/settings/agent-configuration/view 2023-10-31
GET /api/apm/settings/agent-configuration/environments 2023-10-31
GET /api/apm/settings/agent-configuration/agent_name 2023-10-31
POST /api/apm/fleet/apm_server_schema 2023-10-31
```
@miloszmarcinkowski miloszmarcinkowski mentioned this issue Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miloszmarcinkowski miloszmarcinkowski

Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Set explicit access options for APM public APIs miloszmarcinkowski/kibana
4 participants
@smith @kpatticha @elasticmachine @miloszmarcinkowski