Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Inventory] Promote new inventory plugin in APM (#193997) #194443

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Closes elastic#192856.

This PR removes the ability to enable the new APM experience and
replaces it with a link promoting the new Inventory feature.

![Screen Recording 2024-09-25 at 15 02
29](https://github.com/user-attachments/assets/5dc6b8af-f207-43e5-8125-fffb4b823e4d)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 9f9d911)
@kibanamachine kibanamachine enabled auto-merge (squash) September 30, 2024 14:43
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Sep 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibanamachine kibanamachine merged commit ad413cc into elastic:8.x Sep 30, 2024
27 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1871 1852 -19
observabilityShared 209 210 +1
total -18

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityShared 473 478 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB -28.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 40.4KB 40.2KB -254.0B
observabilityShared 71.1KB 71.6KB +489.0B
total +235.0B
Unknown metric groups

API count

id before after diff
observabilityShared 478 483 +5

miscellaneous assets size

id before after diff
apm 1.3MB 1.3MB -68.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @iblancof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants