Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove library and drilldown notifications #190797

Merged
merged 68 commits into from
Sep 9, 2024

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Aug 20, 2024

Summary

Pre-req for #182535.

We're removing the linked to library and drilldown notifications as part of the panel hover actions redesign which gets rid of the title bar in edit mode. We want to prevent panels from having a title bar when titles are hidden and believe these notifications are no longer necessary. The only notification retained is the panel filter notification.

Screenshot 2024-08-20 at 6 34 16 AM Screenshot 2024-08-20 at 6 37 18 AM

I also did some cleanup and removed unused page objects from the vis, dashboard, and discover functional tests.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.16.0 labels Aug 20, 2024
@cqliu1 cqliu1 requested review from a team as code owners August 20, 2024 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@cqliu1 cqliu1 changed the title [Dashboard] Remove linked to library notification [Dashboard] Remove library and drilldown notifications Aug 20, 2024
@botelastic botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Aug 20, 2024
@cqliu1
Copy link
Contributor Author

cqliu1 commented Aug 20, 2024

/ci

Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis changes LGTM 🎉

@nickpeihl nickpeihl self-requested a review August 26, 2024 17:12
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I left a couple nits, but nothing that has to block merging this.

code review and tested changes to notifications.

@@ -76,7 +76,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await common.waitForSaveModalToClose();
await testSubjects.exists('addObjectToDashboardSuccess');
await testSubjects.existOrFail('links--component');
await testSubjects.existOrFail('embeddablePanelNotification-ACTION_LIBRARY_NOTIFICATION');
await dashboardPanelActions.expectLinkedToLibrary(LINKS_PANEL_NAME);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this assertion is much better now.

async legacyUnlinkFromLibraryByTitle(title = '') {
this.log.debug(`legacyUnlinkFromLibraryByTitle(${title}`);
const header = await this.getPanelHeading(title);
await this.legacyUnlinkFromLibrary(header);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, should we move the await this.clickContextMenuItem(LEGACY_UNLINK_FROM_LIBRARY_TEST_SUBJ, parent); line from legacyUnlinkFromLibrary into this method? Then I think we could get rid of legacyUnlinkFromLibrary completely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what I'll do here is have all of the panel actions helpers receive title strings instead of header web elements

async unlinkFromLibraryByTitle(title = '') {
this.log.debug(`unlinkFromLibraryByTitle(${title})`);
const header = await this.getPanelHeading(title);
await this.unlinkFromLibrary(header);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, same comment as above. It seems unnecessary to keep the unlinkFromLibrary method that only has a single line.

@@ -88,7 +81,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

describe('nick by reference', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 nick 😛

@cqliu1 cqliu1 added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 9, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 564 561 -3
embeddableEnhanced 45 44 -1
total -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 461.2KB 457.5KB -3.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddableEnhanced 10.7KB 8.9KB -1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cqliu1

@cqliu1 cqliu1 merged commit 3d8fad5 into elastic:main Sep 9, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 9, 2024
@cqliu1 cqliu1 deleted the dashboard/remove-library-notification branch September 9, 2024 21:11
wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Oct 11, 2024
Contributes to: elastic#194817

Why I assigned them:

Assigned advanced_settings due to elastic#175255

Assigned dashboard_controls due to elastic#190797

Assigned dashboard_links due to elastic#174772

Assigned dashboard_panel_options due to elastic#178596

Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned helpers due to elastic#164341 (call site)

Assigned home due to elastic#103192

Assigned index_lifecycle_management due to elastic#116207

Assigned ingest_node_pipelines due to elastic#113783

Assigned kibana_overview due to  https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned management due to elastic#165705

Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4

Assigned search_profiler due to elastic#195343

Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4

Assigned lens due to elastic#175893

Assigned ml_anomaly_detection due to elastic#162126

Assigned canvas due to elastic#164376

Assigned cc replication due to elastic#149069

Assigned enterpise search due to elastic#79359

Assigned graph to due elastic#190797

Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4

Assigned maps due to elastic#155161

Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4

Assigned remote clusters due to elastic#96989

Assigned reporting due to elastic#121435

Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4

Assigned watcher due to elastic#119717
wayneseymour added a commit that referenced this pull request Oct 22, 2024
## Summary

Assign files within `x-pack/test/accessibility/apps/group[1|2|3]`

### Why I assigned them:

Assigned advanced_settings due to
#175255

Assigned dashboard_controls due to
#190797

Assigned dashboard_links due to
#174772

Assigned dashboard_panel_options due to
#178596

Assigned grok_debugger due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned helpers due to #164341
(call site)

Assigned home due to #103192

Assigned index_lifecycle_management due to
#116207

Assigned ingest_node_pipelines due to
#113783

Assigned kibana_overview due to
https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4

Assigned management due to #165705

Assigned painless_lab due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4

Assigned search_profiler due to
#195343

Assigned uptime due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4

Assigned lens due to #175893

Assigned ml_anomaly_detection due to
#162126

Assigned canvas due to #164376

Assigned cc replication due to
#149069

Assigned enterpise search due to
#79359

Assigned graph to due #190797

Assigned license_management due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4

Assigned maps due to #155161

Assigned observability due to
https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4

Assigned remote clusters due to
#96989

Assigned reporting due to #121435

Assigned rollup_jobs due to
https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4

Assigned watcher due to #119717


Contributes to: #194817

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Rodney Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features Feature:Drilldowns Embeddable panel Drilldowns impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants