-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Reorganize panel actions #178596
Conversation
Hey hey @cqliu1 , just looking at the words in the panel actions we could maybe change some.
I think the other actions are good as they are because they are very descriptive. I won't be offended if we don't change any of the actions |
@teresaalvarezsoler Can we do this reorg without using the dividers in the |
@cqliu1 absolutely, let's do it without dividers. This menu will anyway change when we do hover actions so let's keep it to the minimum possible effort for now. |
Pinging @elastic/kibana-presentation (Team:Presentation) |
@@ -28,7 +28,7 @@ export function createVisToADJobAction( | |||
}, | |||
getDisplayName: () => | |||
i18n.translate('xpack.ml.actions.createADJobFromLens', { | |||
defaultMessage: 'Create anomaly detection job', | |||
defaultMessage: 'Detect anomaly', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultMessage: 'Detect anomaly', | |
defaultMessage: 'Detect anomalies', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated copy in 2ecb655 👍
…iu1/kibana into dashboard/actions-menu-reorg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cases changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally + code review - LGTM, minus a few lines that should be removed 👍 Great job on this!
..._enhanced/public/services/drilldowns/actions/flyout_edit_drilldown/flyout_edit_drilldown.tsx
Outdated
Show resolved
Hide resolved
...anced/public/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design changes LGTM. Thanks!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vis changes LGTM 🎉
Contributes to: elastic#194817 Why I assigned them: Assigned advanced_settings due to elastic#175255 Assigned dashboard_controls due to elastic#190797 Assigned dashboard_links due to elastic#174772 Assigned dashboard_panel_options due to elastic#178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to elastic#164341 (call site) Assigned home due to elastic#103192 Assigned index_lifecycle_management due to elastic#116207 Assigned ingest_node_pipelines due to elastic#113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to elastic#165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to elastic#195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to elastic#175893 Assigned ml_anomaly_detection due to elastic#162126 Assigned canvas due to elastic#164376 Assigned cc replication due to elastic#149069 Assigned enterpise search due to elastic#79359 Assigned graph to due elastic#190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to elastic#155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to elastic#96989 Assigned reporting due to elastic#121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to elastic#119717
## Summary Assign files within `x-pack/test/accessibility/apps/group[1|2|3]` ### Why I assigned them: Assigned advanced_settings due to #175255 Assigned dashboard_controls due to #190797 Assigned dashboard_links due to #174772 Assigned dashboard_panel_options due to #178596 Assigned grok_debugger due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned helpers due to #164341 (call site) Assigned home due to #103192 Assigned index_lifecycle_management due to #116207 Assigned ingest_node_pipelines due to #113783 Assigned kibana_overview due to https://github.com/elastic/kibana/blob/f00ac7a8a21463e6bb4a2784c3a3884f36c62900/x-pack/plugins/grokdebugger/kibana.jsonc#L4 Assigned management due to #165705 Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L4 Assigned search_profiler due to #195343 Assigned uptime due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/uptime/kibana.jsonc#L4 Assigned lens due to #175893 Assigned ml_anomaly_detection due to #162126 Assigned canvas due to #164376 Assigned cc replication due to #149069 Assigned enterpise search due to #79359 Assigned graph to due #190797 Assigned license_management due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/license_management/kibana.jsonc#L4 Assigned maps due to #155161 Assigned observability due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/observability/kibana.jsonc#L4 Assigned remote clusters due to #96989 Assigned reporting due to #121435 Assigned rollup_jobs due to https://github.com/elastic/kibana/blob/d57bc9a5d7d64f86b550eff7997605a3090aee9a/x-pack/plugins/rollup/kibana.jsonc#L4 Assigned watcher due to #119717 Contributes to: #194817 --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Rodney Norris <[email protected]>
## Summary Updated instructions and visuals for the new hover actions feature. Also came across a mention of the Replace panel action and removed it ([#178596](#178596)). Rel: [#182535](#182535) and [#596](elastic/platform-docs-team#596) Closes: [#580](elastic/platform-docs-team#580)
## Summary Updated instructions and visuals for the new hover actions feature. Also came across a mention of the Replace panel action and removed it ([elastic#178596](elastic#178596)). Rel: [elastic#182535](elastic#182535) and [elastic#596](elastic/platform-docs-team#596) Closes: [elastic#580](elastic/platform-docs-team#580) (cherry picked from commit 5b8ffd6)
# Backport This will backport the following commits from `main` to `8.x`: - [[Docs] Update dashboard docs for hover actions (#204844)](#204844) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"wajihaparvez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-20T00:50:43Z","message":"[Docs] Update dashboard docs for hover actions (#204844)\n\n## Summary\r\n\r\nUpdated instructions and visuals for the new hover actions feature. \r\nAlso came across a mention of the Replace panel action and removed it\r\n([#178596](https://github.com/elastic/kibana/pull/178596)).\r\n\r\nRel: [#182535](#182535) and\r\n[#596](https://github.com/elastic/platform-docs-team/issues/596)\r\nCloses: [#580](https://github.com/elastic/platform-docs-team/issues/580)","sha":"5b8ffd6d985b5e6e5597879fb2e0f6a17ed6d53c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","Team:Presentation","release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0"],"title":"[Docs] Update dashboard docs for hover actions","number":204844,"url":"https://github.com/elastic/kibana/pull/204844","mergeCommit":{"message":"[Docs] Update dashboard docs for hover actions (#204844)\n\n## Summary\r\n\r\nUpdated instructions and visuals for the new hover actions feature. \r\nAlso came across a mention of the Replace panel action and removed it\r\n([#178596](https://github.com/elastic/kibana/pull/178596)).\r\n\r\nRel: [#182535](#182535) and\r\n[#596](https://github.com/elastic/platform-docs-team/issues/596)\r\nCloses: [#580](https://github.com/elastic/platform-docs-team/issues/580)","sha":"5b8ffd6d985b5e6e5597879fb2e0f6a17ed6d53c"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204844","number":204844,"mergeCommit":{"message":"[Docs] Update dashboard docs for hover actions (#204844)\n\n## Summary\r\n\r\nUpdated instructions and visuals for the new hover actions feature. \r\nAlso came across a mention of the Replace panel action and removed it\r\n([#178596](https://github.com/elastic/kibana/pull/178596)).\r\n\r\nRel: [#182535](#182535) and\r\n[#596](https://github.com/elastic/platform-docs-team/issues/596)\r\nCloses: [#580](https://github.com/elastic/platform-docs-team/issues/580)","sha":"5b8ffd6d985b5e6e5597879fb2e0f6a17ed6d53c"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: wajihaparvez <[email protected]>
[Docs] Update dashboard docs for hover actions (elastic#204844) Updated instructions and visuals for the new hover actions feature. Also came across a mention of the Replace panel action and removed it ([elastic#178596](elastic#178596)). Rel: [elastic#182535](elastic#182535) and [elastic#596](elastic/platform-docs-team#596) Closes: [elastic#580](elastic/platform-docs-team#580)
Summary
Closes #177254.
This updates the order panel actions appear in the actions menu. This also deletes the
Replace panel
action.Top level
More
Changes:
More
sub-menuDelete from dashboard
onto the top level actions menuReplace panel
actionAdd to new case
actionAdd to existing case
action ->Add to case
Create anomaly detection job
action ->Detect anomalies
Clone panel
action ->Duplicate
Panel settings
action ->Settings
Delete from dashboard
action ->Remove
Explore data in Discover
action ->Explore in Discover
Download as CSV
action ->Download CSV
Maximize panel
action ->Maximize
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers