[Dashboard] Reorganize panel actions

src/plugins/dashboard/public/dashboard_actions/_dashboard_actions_strings.ts

@@ -51,15 +51,15 @@ export const dashboardAddToLibraryActionStrings = {
 export const dashboardClonePanelActionStrings = {
   getDisplayName: () =>
     i18n.translate('dashboard.panel.clonePanel', {
-      defaultMessage: 'Clone panel',
+      defaultMessage: 'Duplicate',
     }),
   getClonedTag: () =>
     i18n.translate('dashboard.panel.title.clonedTag', {
       defaultMessage: 'copy',
     }),
   getSuccessMessage: () =>
     i18n.translate('dashboard.panel.clonedToast', {
-      defaultMessage: 'Cloned panel',
+      defaultMessage: 'Duplicated panel',
     }),
 };
 
@@ -70,14 +70,14 @@ export const dashboardExpandPanelActionStrings = {
     }),
   getMaximizeTitle: () =>
     i18n.translate('dashboard.actions.toggleExpandPanelMenuItem.notExpandedDisplayName', {
-      defaultMessage: 'Maximize panel',
+      defaultMessage: 'Maximize',
     }),
 };
 
 export const dashboardExportCsvActionStrings = {
   getDisplayName: () =>
     i18n.translate('dashboard.actions.DownloadCreateDrilldownAction.displayName', {
-      defaultMessage: 'Download as CSV',
+      defaultMessage: 'Download CSV',
     }),
   getUntitledFilename: () =>
     i18n.translate('dashboard.actions.downloadOptionsUnsavedFilename', {
@@ -118,35 +118,6 @@ export const dashboardLibraryNotificationStrings = {
     }),
 };
 
-export const dashboardReplacePanelActionStrings = {
-  getDisplayName: () =>
-    i18n.translate('dashboard.panel.removePanel.replacePanel', {
-      defaultMessage: 'Replace panel',
-    }),
-  getFlyoutHeader: (panelName?: string) =>
-    i18n.translate('dashboard.panel.replacePanel.flyoutHeader', {
-      defaultMessage: 'Replace panel {panelName} with:',
-      values: {
-        panelName: `'${panelName}'`,
-      },
-    }),
-  getSuccessMessage: (savedObjectName?: string) =>
-    savedObjectName
-      ? i18n.translate('dashboard.addPanel.savedObjectAddedToContainerSuccessMessageTitle', {
-          defaultMessage: '{savedObjectName} was added',
-          values: {
-            savedObjectName: `'${savedObjectName}'`,
-          },
-        })
-      : i18n.translate('dashboard.addPanel.panelAddedToContainerSuccessMessageTitle', {
-          defaultMessage: 'A panel was added',
-        }),
-  getNoMatchingObjectsMessage: () =>
-    i18n.translate('dashboard.addPanel.noMatchingObjectsMessage', {
-      defaultMessage: 'No matching objects found.',
-    }),
-};
-
 export const dashboardFilterNotificationActionStrings = {
   getDisplayName: () =>
     i18n.translate('dashboard.panel.filters', {

src/plugins/dashboard/public/dashboard_actions/add_to_library_action.tsx

@@ -57,7 +57,7 @@ const isApiCompatible = (api: unknown | null): api is AddPanelToLibraryActionApi
 export class AddToLibraryAction implements Action<EmbeddableApiContext> {
   public readonly type = ACTION_ADD_TO_LIBRARY;
   public readonly id = ACTION_ADD_TO_LIBRARY;
-  public order = 15;
+  public order = 8;
 
   private toastsService;
 

src/plugins/dashboard/public/dashboard_actions/expand_panel_action.test.tsx

@@ -46,7 +46,7 @@ describe('Expand panel action', () => {
   });
 
   it('returns the correct display name based on expanded panel id', async () => {
-    expect(await action.getDisplayName(context)).toBe('Maximize panel');
+    expect(await action.getDisplayName(context)).toBe('Maximize');
     context.embeddable.parentApi.expandedPanelId = new BehaviorSubject<string | undefined>(
       'superPanelId'
     );

src/plugins/dashboard/public/dashboard_actions/export_csv_action.tsx

@@ -40,7 +40,7 @@ const isApiCompatible = (api: unknown | null): api is ExportCsvActionApi =>
 export class ExportCSVAction implements Action<ExportContext> {
   public readonly id = ACTION_EXPORT_CSV;
   public readonly type = ACTION_EXPORT_CSV;
-  public readonly order = 5;
+  public readonly order = 18; // right after Export in discover which is 19
 
   private fieldFormats;
   private uiSettings;

src/plugins/dashboard/public/dashboard_actions/index.ts

@@ -8,10 +8,6 @@
 
 import { CoreStart } from '@kbn/core/public';
 import { CONTEXT_MENU_TRIGGER, PANEL_NOTIFICATION_TRIGGER } from '@kbn/embeddable-plugin/public';
-import {
-  getSavedObjectFinder,
-  SavedObjectFinderProps,
-} from '@kbn/saved-objects-finder-plugin/public';
 
 import { DashboardStartDependencies } from '../plugin';
 import { AddToLibraryAction } from './add_to_library_action';
@@ -22,7 +18,6 @@ import { ExpandPanelAction } from './expand_panel_action';
 import { ExportCSVAction } from './export_csv_action';
 import { FiltersNotificationAction } from './filters_notification_action';
 import { LegacyLibraryNotificationAction } from './legacy_library_notification_action';
-import { ReplacePanelAction } from './replace_panel_action';
 import { UnlinkFromLibraryAction } from './unlink_from_library_action';
 import { LegacyUnlinkFromLibraryAction } from './legacy_unlink_from_library_action';
 import { LibraryNotificationAction } from './library_notification_action';
@@ -33,28 +28,16 @@ interface BuildAllDashboardActionsProps {
   plugins: DashboardStartDependencies;
 }
 
-export type ReplacePanelSOFinder = (props: Omit<SavedObjectFinderProps, 'services'>) => JSX.Element;
-
 export const buildAllDashboardActions = async ({
   core,
   plugins,
   allowByValueEmbeddables,
 }: BuildAllDashboardActionsProps) => {
-  const { uiActions, share, savedObjectsTaggingOss, contentManagement } = plugins;
+  const { uiActions, share } = plugins;
 
   const clonePanelAction = new ClonePanelAction();
   uiActions.registerAction(clonePanelAction);
   uiActions.attachAction(CONTEXT_MENU_TRIGGER, clonePanelAction.id);
-
-  const SavedObjectFinder = getSavedObjectFinder(
-    contentManagement.client,
-    core.uiSettings,
-    savedObjectsTaggingOss?.getTaggingApi()
-  );
-  const changeViewAction = new ReplacePanelAction(SavedObjectFinder as ReplacePanelSOFinder);
-  uiActions.registerAction(changeViewAction);
-  uiActions.attachAction(CONTEXT_MENU_TRIGGER, changeViewAction.id);
-
   const expandPanelAction = new ExpandPanelAction();
   uiActions.registerAction(expandPanelAction);
   uiActions.attachAction(CONTEXT_MENU_TRIGGER, expandPanelAction.id);