Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove library and drilldown notifications #190797

Merged
merged 68 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
405acd2
Remove linked to library notification
cqliu1 Aug 20, 2024
3bf89fb
Fix translations
cqliu1 Aug 20, 2024
052f9d9
Remove panel notifications registration
cqliu1 Aug 20, 2024
8a39a07
Fix drilldown counter helper
cqliu1 Aug 20, 2024
33d14b7
Fix circular dependency
cqliu1 Aug 20, 2024
194f0f2
Remove unused service
cqliu1 Aug 20, 2024
9d8a734
Remove unused page objects
cqliu1 Aug 20, 2024
2ccc2cc
Fix tests
cqliu1 Aug 21, 2024
8688cf1
Remove exclusive suite
cqliu1 Aug 26, 2024
9898429
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Aug 26, 2024
4f877b8
Remove code
cqliu1 Aug 26, 2024
7dbea93
Apply feedback
cqliu1 Aug 26, 2024
82fe473
Merge branch 'main' into dashboard/remove-library-notification
cqliu1 Aug 27, 2024
3d7864b
Remove exclusive suite
cqliu1 Aug 27, 2024
f9873f1
Fix unlink from library tests
cqliu1 Aug 27, 2024
ff09e30
Fix drilldown count
cqliu1 Aug 27, 2024
1a5f02f
fix some link to libary tests
cqliu1 Aug 27, 2024
0080489
Fix more tests
cqliu1 Aug 27, 2024
5be31ce
Fix drilldown count
cqliu1 Aug 27, 2024
cb38d99
Clean up panel actions
cqliu1 Aug 27, 2024
fd329bb
fix canConvertToLens
cqliu1 Aug 28, 2024
9e329e9
Fix drilldown count tests
cqliu1 Aug 28, 2024
c4fcf5b
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Aug 28, 2024
a1e2176
Fix image embeddable tests
cqliu1 Aug 28, 2024
bcbcf8c
Fix panel drilldown actions service
cqliu1 Aug 28, 2024
5b9b1d0
Fix drilldown count
cqliu1 Aug 29, 2024
93485bb
Fix tests
cqliu1 Aug 29, 2024
ba35cef
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Aug 29, 2024
6ec3a25
Fix linting
cqliu1 Aug 29, 2024
843d1ad
Fix time to visualize security tests
cqliu1 Aug 29, 2024
15b2092
Open context menu before more menu
cqliu1 Aug 29, 2024
1a0dd09
Clean up
cqliu1 Aug 29, 2024
a29ae9a
Clean up page objects
cqliu1 Aug 29, 2024
9baafb3
Clean up page objects for vis, presentation, and discover
cqliu1 Aug 29, 2024
cd26ba3
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Aug 29, 2024
1c991c0
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Aug 29, 2024
accff3e
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Aug 29, 2024
d567c1c
Fix type errors
cqliu1 Aug 29, 2024
1add2f1
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Aug 29, 2024
be4fc90
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Aug 30, 2024
3f58082
Fix lint errors
cqliu1 Aug 30, 2024
1df5614
Fix more tests
cqliu1 Aug 30, 2024
e255241
Merge branch 'dashboard/remove-library-notification' of https://githu…
cqliu1 Aug 30, 2024
7c42e8b
Fix drilldown count lop
cqliu1 Aug 30, 2024
a54b49d
Remove page object
cqliu1 Aug 30, 2024
9375115
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Aug 30, 2024
99857dd
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Aug 30, 2024
79429df
Fix lens test
cqliu1 Aug 30, 2024
543f8f0
Fix link to library panel actions
cqliu1 Aug 30, 2024
6cefb0e
Fix lens test
cqliu1 Aug 30, 2024
d6963c0
Fix expectLinkedToLibrary
cqliu1 Aug 30, 2024
b1fa6d3
Fix embeddable library test
cqliu1 Aug 30, 2024
cf6284f
Update panel drilldown actions
cqliu1 Sep 3, 2024
25cce7c
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Sep 3, 2024
901f421
Fix click manage drilldown
cqliu1 Sep 3, 2024
395bd8c
Fix legacy vis library tests
cqliu1 Sep 3, 2024
4401259
Remove exclusive suite
cqliu1 Sep 3, 2024
25c4c68
Fix more tests
cqliu1 Sep 3, 2024
84b163c
Fix more tests
cqliu1 Sep 4, 2024
2b106f8
Fix time to visualize security
cqliu1 Sep 5, 2024
01a150c
Fix tsvb test
cqliu1 Sep 6, 2024
1943bb6
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Sep 6, 2024
fbb010b
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Sep 6, 2024
4ba8961
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 Sep 9, 2024
5684a21
Fix merge conflict
cqliu1 Sep 9, 2024
b38c495
fix more tests
cqliu1 Sep 9, 2024
8094cf7
Fix serverless tests
cqliu1 Sep 9, 2024
2d78569
Remove duplicate service
cqliu1 Sep 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/plugins/dashboard/public/dashboard_actions/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ import { CopyToDashboardAction } from './copy_to_dashboard_action';
import { ExpandPanelAction } from './expand_panel_action';
import { ExportCSVAction } from './export_csv_action';
import { FiltersNotificationAction } from './filters_notification_action';
import { LegacyLibraryNotificationAction } from './legacy_library_notification_action';
import { UnlinkFromLibraryAction } from './unlink_from_library_action';
import { LegacyUnlinkFromLibraryAction } from './legacy_unlink_from_library_action';
import { LibraryNotificationAction } from './library_notification_action';

interface BuildAllDashboardActionsProps {
core: CoreStart;
Expand Down Expand Up @@ -63,20 +61,10 @@ export const buildAllDashboardActions = async ({
uiActions.registerAction(unlinkFromLibraryAction);
uiActions.attachAction(CONTEXT_MENU_TRIGGER, unlinkFromLibraryAction.id);

const libraryNotificationAction = new LibraryNotificationAction(unlinkFromLibraryAction);
uiActions.registerAction(libraryNotificationAction);
uiActions.attachAction(PANEL_NOTIFICATION_TRIGGER, libraryNotificationAction.id);

const legacyUnlinkFromLibraryAction = new LegacyUnlinkFromLibraryAction();
uiActions.registerAction(legacyUnlinkFromLibraryAction);
uiActions.attachAction(CONTEXT_MENU_TRIGGER, legacyUnlinkFromLibraryAction.id);

const legacyLibraryNotificationAction = new LegacyLibraryNotificationAction(
legacyUnlinkFromLibraryAction
);
uiActions.registerAction(legacyLibraryNotificationAction);
uiActions.attachAction(PANEL_NOTIFICATION_TRIGGER, legacyLibraryNotificationAction.id);

const copyToDashboardAction = new CopyToDashboardAction(core);
uiActions.registerAction(copyToDashboardAction);
uiActions.attachAction(CONTEXT_MENU_TRIGGER, copyToDashboardAction.id);
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading