-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17][Rollup] Unskip 7.17 rollup API integration tests #187339
Merged
ElenaStoeva
merged 6 commits into
elastic:7.17
from
ElenaStoeva:7.17/rollup-api-integration-tests
Jul 15, 2024
Merged
[7.17][Rollup] Unskip 7.17 rollup API integration tests #187339
ElenaStoeva
merged 6 commits into
elastic:7.17
from
ElenaStoeva:7.17/rollup-api-integration-tests
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Rollups
labels
Jul 2, 2024
Pinging @elastic/kibana-management (Team:Kibana Management) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
@elasticmachine merge upstream |
alisonelizabeth
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the tests!
x-pack/test/api_integration/apis/management/rollup/index_patterns_extensions.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alison Goryachev <[email protected]>
💚 Build Succeeded
Metrics [docs]
History
cc @ElenaStoeva |
This was referenced Jul 16, 2024
adelisle
pushed a commit
to Makila-AI/kibana
that referenced
this pull request
Aug 5, 2024
Fixes elastic#184275 Fixes elastic#184227 ## Summary This PR unskips the 7.17 rollup API integration tests which failed during the 7.17 ES 8.15 forward compatibility tests. To run the tests locally with ES 8.15: ``` ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.15.0/manifest-latest-verified.json" node scripts/functional_tests_server.js --config x-pack/test/api_integration/config.ts ``` ``` ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.15.0/manifest-latest-verified.json" node scripts/functional_test_runner.js --config x-pack/test/api_integration/config.ts --grep="rollup" ``` --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Alison Goryachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Rollups
release_note:skip
Skip the PR/issue when compiling release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v7.17.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184275
Fixes #184227
Summary
This PR unskips the 7.17 rollup API integration tests which failed during the 7.17 ES 8.15 forward compatibility tests.
To run the tests locally with ES 8.15: