Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17][Rollup] Unskip 7.17 rollup functional tests #187350

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

ElenaStoeva
Copy link
Contributor

Fixes #184229
Fixes #184230
Fixes #184277
Fixes #184278
Fixes #184357
Fixes #57065

Summary

This PR unskips the 7.17 rollup functional tests which failed during the 7.17 ES 8.15 forward compatibility tests.

To run the tests locally with ES 8.15:

ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.15.0/manifest-latest-verified.json" node scripts/functional_tests_server.js --config x-pack/test/functional/config.js
ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.15.0/manifest-latest-verified.json" node scripts/functional_test_runner.js --config x-pack/test/functional/config.js --grep="rollup job"

@ElenaStoeva ElenaStoeva added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Rollups v7.17.0 labels Jul 2, 2024
@ElenaStoeva ElenaStoeva requested a review from a team July 2, 2024 11:35
@ElenaStoeva ElenaStoeva self-assigned this Jul 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests!

@alisonelizabeth
Copy link
Contributor

(I see there is a failure but it looks unrelated to the rollup tests; may just need to rerun CI)

Co-authored-by: Alison Goryachev <[email protected]>
@ElenaStoeva ElenaStoeva enabled auto-merge (squash) July 15, 2024 17:52
@ElenaStoeva ElenaStoeva merged commit 05f4e98 into elastic:7.17 Jul 15, 2024
106 of 107 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @ElenaStoeva

adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024
Fixes elastic#184229
Fixes elastic#184230
Fixes elastic#184277
Fixes elastic#184278
Fixes elastic#184357
Fixes elastic#57065

## Summary

This PR unskips the 7.17 rollup functional tests which failed during the
7.17 ES 8.15 forward compatibility tests.

To run the tests locally with ES 8.15:

```
ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.15.0/manifest-latest-verified.json" node scripts/functional_tests_server.js --config x-pack/test/functional/config.js
```

```
ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.15.0/manifest-latest-verified.json" node scripts/functional_test_runner.js --config x-pack/test/functional/config.js --grep="rollup job"

```

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Alison Goryachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants