Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Integration non-default dataset is now marked as part of the integration #182097

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Apr 30, 2024

Closes #181542

📝 Summary

This PR usesIndicesDataStream metadata info to determine whether a non-default dataset belongs to an integration or not

🎥 Demo

Before changes

Screen.Recording.2024-04-24.at.15.21.37.mov

After changes

Screen.Recording.2024-04-26.at.14.47.31.mov

@yngrdyn yngrdyn requested a review from a team as a code owner April 30, 2024 10:24
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Apr 30, 2024
@yngrdyn yngrdyn self-assigned this Apr 30, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Apr 30, 2024
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 30, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 168.3KB 168.7KB +322.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5875 +5875
total size - 6.7MB +6.7MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 36.0KB 36.2KB +263.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@yngrdyn yngrdyn merged commit 6910e0c into elastic:main Apr 30, 2024
19 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dataset quality] 🐞 Dataset is not marked as part of the integration
5 participants