Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] 🐞 Dataset is not marked as part of the integration #181542

Closed
yngrdyn opened this issue Apr 24, 2024 · 4 comments · Fixed by #181836 or #182097
Closed

[Dataset quality] 🐞 Dataset is not marked as part of the integration #181542

yngrdyn opened this issue Apr 24, 2024 · 4 comments · Fixed by #181836 or #182097
Assignees
@yngrdyn
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Apr 24, 2024 •
edited
Loading

In #180560 we separated the integrations request from the DataStreamStats one, as part of the separation we are discovering datasets from integrations directly, the problem with this comes with datasets that are not the default/original ones for example these ones in APM

image

They should be marked as part of APM integration.
@yngrdyn yngrdyn added bug Fixes for quality problems that affect the customer experience Team:obs-ux-logs Observability Logs User Experience Team Feature:Dataset Health labels Apr 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@yngrdyn yngrdyn self-assigned this Apr 24, 2024
@yngrdyn yngrdyn changed the title [Dataset quality] Dataset is not marked as part of the integration [Dataset quality] 🐞 Dataset is not marked as part of the integration Apr 24, 2024
@weltenwort
Copy link
Member

This is a tricky one. I would love to hear what your plans are for this.

@yngrdyn
Copy link
Contributor Author

yngrdyn commented Apr 26, 2024 •
edited
Loading

@weltenwort I'm planning to use the metadata in IndicesDataStream. There we can get a reference of package name, that could help us in the matching process.

@yngrdyn yngrdyn mentioned this issue Apr 26, 2024
Merged
@weltenwort
Copy link
Member

Interesting, I wasn't aware that these metadata exist. Thanks for the explanation!

yngrdyn added a commit that referenced this issue Apr 29, 2024
@yngrdyn @mohamedhamed-ahmed
[Dataset quality] Integration non-default dataset is now marked as pa…
4ad5d46 
…rt of the integration (#181836)

Closes #181542

## 📝  Summary

This PR uses`IndicesDataStream` metadata info to determine whether a
non-default dataset belongs to an integration or not

## 🎥 Demo

### Before changes


https://github.com/elastic/kibana/assets/1313018/23fbbb9d-ae52-4e30-b525-8176f89d6462



### After changes


https://github.com/elastic/kibana/assets/1313018/5423dba2-fbcf-47b4-87b7-2987f5a1f6d2

---------

Co-authored-by: mohamedhamed-ahmed <[email protected]>
@yngrdyn yngrdyn mentioned this issue Apr 30, 2024
Merged
yngrdyn added a commit that referenced this issue Apr 30, 2024
@yngrdyn @mohamedhamed-ahmed
[Dataset quality] Integration non-default dataset is now marked as pa…
6910e0c 
…rt of the integration (#182097)

Closes #181542

## 📝  Summary

This PR uses`IndicesDataStream` metadata info to determine whether a
non-default dataset belongs to an integration or not

## 🎥 Demo

### Before changes


https://github.com/elastic/kibana/assets/1313018/23fbbb9d-ae52-4e30-b525-8176f89d6462


### After changes


https://github.com/elastic/kibana/assets/1313018/5423dba2-fbcf-47b4-87b7-2987f5a1f6d2

---------

Co-authored-by: mohamedhamed-ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yngrdyn yngrdyn

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
3 participants
@weltenwort @yngrdyn @elasticmachine