Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] Integration non-default dataset is now marked as part of the integration #181836

Merged
merged 6 commits into from
Apr 29, 2024
Merged

[Dataset quality] Integration non-default dataset is now marked as part of the integration #181836

merged 6 commits into from
Apr 29, 2024

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Apr 26, 2024

Closes #181542

📝 Summary

This PR usesIndicesDataStream metadata info to determine whether a non-default dataset belongs to an integration or not

🎥 Demo

Before changes

Screen.Recording.2024-04-24.at.15.21.37.mov

After changes

Screen.Recording.2024-04-26.at.14.47.31.mov

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Apr 26, 2024
@yngrdyn yngrdyn self-assigned this Apr 26, 2024
@yngrdyn yngrdyn requested a review from a team as a code owner April 26, 2024 12:50
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mohamedhamed-ahmed mohamedhamed-ahmed self-requested a review April 26, 2024 16:02
mohamedhamed-ahmed
mohamedhamed-ahmed approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! solution looks clean and straightforward

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Apr 29, 2024
yngrdyn added 2 commits April 29, 2024 14:41
@yngrdyn
fixing PR comments
1e35bc4
@yngrdyn
Merge branch '181542-dataset-quality-dataset-is-not-marked-as-part-of…
cd719ac 
…-the-integration' of github.com:yngrdyn/kibana into 181542-dataset-quality-dataset-is-not-marked-as-part-of-the-integration
@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 29, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 168.3KB 168.6KB +298.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5874 +5874
total size - 6.7MB +6.7MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 36.0KB 36.2KB +273.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@yngrdyn yngrdyn merged commit 4ad5d46 into elastic:main Apr 29, 2024
18 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 29, 2024
delanni added a commit to delanni/kibana that referenced this pull request Apr 29, 2024
@delanni
Revert "[Dataset quality] Integration non-default dataset is now mark…
d74969a 
…ed as part of the integration (elastic#181836)"

This reverts commit 4ad5d46.
@delanni delanni mentioned this pull request Apr 29, 2024
Merged
@delanni
Copy link
Contributor

delanni commented Apr 29, 2024

Reverted in #181999

mistic pushed a commit that referenced this pull request Apr 29, 2024
@delanni
Revert #181836 due to type errors from merge race (#181999)
e3e5037 
## Summary
Revert "[Dataset quality] Integration non-default dataset is now marked
as part of the integration (#181836)"

This reverts commit 4ad5d46.
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Apr 30, 2024

New PR with this code #182097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

Assignees

@yngrdyn yngrdyn

Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes reverted v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dataset quality] 🐞 Dataset is not marked as part of the integration
6 participants
@yngrdyn @apmmachine @kibana-ci @delanni @mohamedhamed-ahmed @kibanamachine