Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NA): getPluginsDistFromRepo to return only dist plugins on build #171457

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

mistic
Copy link
Member

@mistic mistic commented Nov 17, 2023

This PR fixes a problem where the getPluginsDistFromRepo would return every available plugin and not only the dist ones.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.12.0 labels Nov 17, 2023
@mistic mistic marked this pull request as ready for review November 17, 2023 01:12
@mistic mistic requested a review from a team as a code owner November 17, 2023 01:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit 92b6b82 into elastic:main Nov 20, 2023
27 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2023
…lastic#171457)

This PR fixes a problem where the `getPluginsDistFromRepo` would return
every available plugin and not only the dist ones.

(cherry picked from commit 92b6b82)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2023
… build (elastic#171457) (elastic#171504)

# Backport

This will backport the following commits from `main` to `8.11`:
- [fix(NA): getPluginsDistFromRepo to return only dist plugins on build
(elastic#171457)](elastic#171457)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago
Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-20T09:52:53Z","message":"fix(NA):
getPluginsDistFromRepo to return only dist plugins on build
(elastic#171457)\n\nThis PR fixes a problem where the `getPluginsDistFromRepo`
would return\r\nevery available plugin and not only the dist
ones.","sha":"92b6b82d1c9c35db82af3c0d9f7e9c18a68483c8","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:prev-minor","v8.12.0"],"number":171457,"url":"https://github.com/elastic/kibana/pull/171457","mergeCommit":{"message":"fix(NA):
getPluginsDistFromRepo to return only dist plugins on build
(elastic#171457)\n\nThis PR fixes a problem where the `getPluginsDistFromRepo`
would return\r\nevery available plugin and not only the dist
ones.","sha":"92b6b82d1c9c35db82af3c0d9f7e9c18a68483c8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171457","number":171457,"mergeCommit":{"message":"fix(NA):
getPluginsDistFromRepo to return only dist plugins on build
(elastic#171457)\n\nThis PR fixes a problem where the `getPluginsDistFromRepo`
would return\r\nevery available plugin and not only the dist
ones.","sha":"92b6b82d1c9c35db82af3c0d9f7e9c18a68483c8"}}]}] BACKPORT-->

Co-authored-by: Tiago Costa <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Nov 23, 2023
Attempting to merge elastic#170852 again now that the release artefact step has
been fixed as part of elastic#171457

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Aleh Zasypkin <[email protected]>
Co-authored-by: Dzmitry Lemechko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants