Add mock identity provider for serverless (2nd attempt) #171513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess-role-selector
…mann/kibana into serverless-role-selector
…mann/kibana into serverless-role-selector
…mann/kibana into serverless-role-selector
…ess-role-selector
…mann/kibana into serverless-role-selector
Co-authored-by: Aleh Zasypkin <[email protected]>
…ess-role-selector
thomheymann
added
the
release_note:skip
jbudz
reviewed
Nov 20, 2023
jbudz
previously approved these changes
Nov 20, 2023
azasypkin
approved these changes
Nov 21, 2023
jbudz
reviewed
Nov 21, 2023
| // for the ip which is not validated. As such we are getting the error | ||
| // Hostname/IP does not match certificate's altnames: IP: 127.0.0.1 is not in the cert's list: | ||
| // To work around that we are overriding the function checkServerIdentity too | ||
| checkServerIdentity: () => { |
There was a problem hiding this comment.
Did we try binding to localhost instead of 127.0.0.1? While this is a test environment..disabling identity checks for every node url regardless of endpoint seems heavy handed.
There was a problem hiding this comment.
Sorry, I missed that this was already committed and moved to a different spot. I'll table this discussion for another issue.
jbudz
approved these changes
Nov 21, 2023
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.12.0
backport:skip
darnautov
pushed a commit
to darnautov/kibana
that referenced
this pull request
Nov 23, 2023
## Summary This PR disables TLS mode for Kibana run in serverless. Related to elastic#170417 enabling serverless roles testing Blocked by elastic#171513 PR is created in cooperation with @azasypkin and intended to simplify the automated testing process for serverless: starting Kibana with TLS enabled adds unnecessary complexity to the process of getting session cookie and overall Kibana APIs calling with Dev certificate in the tests. The selected approach is to disable TLS for Kibana and simply rely on elastic#171513 to configure mocked idp realm for Serverless ES with TLS enabled. --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to merge #170852 again now that the release artefact step has been fixed as part of #171457