fix(NA): getPluginsDistFromRepo to return only dist plugins on build (#…

…171457)

This PR fixes a problem where the `getPluginsDistFromRepo` would return
every available plugin and not only the dist ones.

src/dev/build/lib/config.ts

@@ -251,6 +251,6 @@ export class Config {
   }
 
   getDistPluginsFromRepo() {
-    return getPackages(this.repoRoot).filter(this.pluginFilter);
+    return getPackages(this.repoRoot).filter((p) => !p.isDevOnly() && this.pluginFilter(p));
   }
 }

src/dev/build/tasks/package_json/create_package_json_tasks.ts

@@ -6,14 +6,15 @@
  * Side Public License, v 1.
  */
 
+import { PluginPackage } from '@kbn/repo-packages';
 import { findUsedDependencies } from './find_used_dependencies';
 import { read, write, Task } from '../../lib';
 
 export const CreatePackageJson: Task = {
   description: 'Creating build-ready version of package.json',
 
   async run(config, log, build) {
-    const plugins = config.getDistPluginsFromRepo();
+    const plugins = config.getDistPluginsFromRepo() as PluginPackage[];
     const distPkgIds = new Set(config.getDistPackagesFromRepo().map((p) => p.id));
     const pkg = config.getKibanaPkg();