[Discover] Revert data table row height to 3 by default #169724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davismcphee
added
release_note:skip
davismcphee
force-pushed
the
revert-redesign-auto-fit-content
branch
from
f0ba9bf to
c376db3
Compare
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
approved these changes
Oct 30, 2023
kertal
approved these changes
Oct 30, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @davismcphee |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2023
## Summary This PR reverts the changes from elastic#164218 that updated the default Discover grid row height to "auto", and changes it back to "3". ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 788d302)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2023
…) (#170187) # Backport This will backport the following commits from `main` to `8.11`: - [[Discover] Revert data table row height to 3 by default (#169724)](#169724) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis McPhee","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-30T20:36:32Z","message":"[Discover] Revert data table row height to 3 by default (#169724)\n\n## Summary\r\n\r\nThis PR reverts the changes from #164218 that updated the default\r\nDiscover grid row height to \"auto\", and changes it back to \"3\".\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"788d30239640e4f549eaeedebad766072de45a05","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","v8.11.0","v8.12.0"],"number":169724,"url":"https://github.com/elastic/kibana/pull/169724","mergeCommit":{"message":"[Discover] Revert data table row height to 3 by default (#169724)\n\n## Summary\r\n\r\nThis PR reverts the changes from #164218 that updated the default\r\nDiscover grid row height to \"auto\", and changes it back to \"3\".\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"788d30239640e4f549eaeedebad766072de45a05"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169724","number":169724,"mergeCommit":{"message":"[Discover] Revert data table row height to 3 by default (#169724)\n\n## Summary\r\n\r\nThis PR reverts the changes from #164218 that updated the default\r\nDiscover grid row height to \"auto\", and changes it back to \"3\".\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"788d30239640e4f549eaeedebad766072de45a05"}}]}] BACKPORT--> --------- Co-authored-by: Davis McPhee <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2023
…w height in Findings (#170503) (#170587) # Backport This will backport the following commits from `main` to `8.11`: - [[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503)](#170503) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Kholod","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-04T14:26:33Z","message":"[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503)\n\n## Summary\r\n\r\nfixes\r\n- https://github.com/elastic/kibana/issues/170502\r\n\r\ndefaulting to row height 0 for the findings table. As the default was -1\r\nbefore, we were defaulting to 0, but due to this change\r\nhttps://github.com//pull/169724/files the default became\r\n3, which broke our table. I guess the logic of taking the UI setting if\r\nit's differnt from default -1 was to cater for users changing the row\r\nheight somewhere in the settings, but we need to bring to product/design\r\nto see if we want to support it\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5b72f77e078ecde5754161c8ba23f1ce63cfeb9f","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v8.12.0"],"number":170503,"url":"https://github.com/elastic/kibana/pull/170503","mergeCommit":{"message":"[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503)\n\n## Summary\r\n\r\nfixes\r\n- https://github.com/elastic/kibana/issues/170502\r\n\r\ndefaulting to row height 0 for the findings table. As the default was -1\r\nbefore, we were defaulting to 0, but due to this change\r\nhttps://github.com//pull/169724/files the default became\r\n3, which broke our table. I guess the logic of taking the UI setting if\r\nit's differnt from default -1 was to cater for users changing the row\r\nheight somewhere in the settings, but we need to bring to product/design\r\nto see if we want to support it\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5b72f77e078ecde5754161c8ba23f1ce63cfeb9f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170503","number":170503,"mergeCommit":{"message":"[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503)\n\n## Summary\r\n\r\nfixes\r\n- https://github.com/elastic/kibana/issues/170502\r\n\r\ndefaulting to row height 0 for the findings table. As the default was -1\r\nbefore, we were defaulting to 0, but due to this change\r\nhttps://github.com//pull/169724/files the default became\r\n3, which broke our table. I guess the logic of taking the UI setting if\r\nit's differnt from default -1 was to cater for users changing the row\r\nheight somewhere in the settings, but we need to bring to product/design\r\nto see if we want to support it\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5b72f77e078ecde5754161c8ba23f1ce63cfeb9f"}}]}] BACKPORT--> Co-authored-by: Maxim Kholod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts the changes from #164218 that updated the default Discover grid row height to "auto", and changes it back to "3".
Checklist
For maintainers