[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings #170503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcold
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
animehart
approved these changes
Nov 3, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2023
…t in Findings (elastic#170503) ## Summary fixes - elastic#170502 defaulting to row height 0 for the findings table. As the default was -1 before, we were defaulting to 0, but due to this change https://github.com/elastic/kibana/pull/169724/files the default became 3, which broke our table. I guess the logic of taking the UI setting if it's differnt from default -1 was to cater for users changing the row height somewhere in the settings, but we need to bring to product/design to see if we want to support it --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 5b72f77)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2023
…w height in Findings (#170503) (#170587) # Backport This will backport the following commits from `main` to `8.11`: - [[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503)](#170503) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Kholod","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-04T14:26:33Z","message":"[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503)\n\n## Summary\r\n\r\nfixes\r\n- https://github.com/elastic/kibana/issues/170502\r\n\r\ndefaulting to row height 0 for the findings table. As the default was -1\r\nbefore, we were defaulting to 0, but due to this change\r\nhttps://github.com//pull/169724/files the default became\r\n3, which broke our table. I guess the logic of taking the UI setting if\r\nit's differnt from default -1 was to cater for users changing the row\r\nheight somewhere in the settings, but we need to bring to product/design\r\nto see if we want to support it\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5b72f77e078ecde5754161c8ba23f1ce63cfeb9f","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v8.12.0"],"number":170503,"url":"https://github.com/elastic/kibana/pull/170503","mergeCommit":{"message":"[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503)\n\n## Summary\r\n\r\nfixes\r\n- https://github.com/elastic/kibana/issues/170502\r\n\r\ndefaulting to row height 0 for the findings table. As the default was -1\r\nbefore, we were defaulting to 0, but due to this change\r\nhttps://github.com//pull/169724/files the default became\r\n3, which broke our table. I guess the logic of taking the UI setting if\r\nit's differnt from default -1 was to cater for users changing the row\r\nheight somewhere in the settings, but we need to bring to product/design\r\nto see if we want to support it\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5b72f77e078ecde5754161c8ba23f1ce63cfeb9f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170503","number":170503,"mergeCommit":{"message":"[Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503)\n\n## Summary\r\n\r\nfixes\r\n- https://github.com/elastic/kibana/issues/170502\r\n\r\ndefaulting to row height 0 for the findings table. As the default was -1\r\nbefore, we were defaulting to 0, but due to this change\r\nhttps://github.com//pull/169724/files the default became\r\n3, which broke our table. I guess the logic of taking the UI setting if\r\nit's differnt from default -1 was to cater for users changing the row\r\nheight somewhere in the settings, but we need to bring to product/design\r\nto see if we want to support it\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"5b72f77e078ecde5754161c8ba23f1ce63cfeb9f"}}]}] BACKPORT--> Co-authored-by: Maxim Kholod <[email protected]>
|
This PR didn't make it into the last BC of 8.11.0. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes
defaulting to row height 0 for the findings table. As the default was -1 before, we were defaulting to 0, but due to this change https://github.com/elastic/kibana/pull/169724/files the default became 3, which broke our table. I guess the logic of taking the UI setting if it's differnt from default -1 was to cater for users changing the row height somewhere in the settings, but we need to bring to product/design to see if we want to support it