Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Resets selected columns when changing query #167492

Merged
merged 1 commit into from
Sep 29, 2023
Merged

[ES|QL] Resets selected columns when changing query #167492

merged 1 commit into from
Sep 29, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 28, 2023 •
edited
Loading

Summary

Fixes a bug in ES|QL mode where you:

  • have a query of index pattern 1 and select some fields
  • change the query by using a different index pattern
  • the selected columns do not reset

BUG
withbug

NOW
now

Checklist

@stratoula stratoula added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.11.0 Feature:ES|QL ES|QL related features in Kibana labels Sep 28, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #5 / serverless common UI Index Management Indices "before all" hook for "renders the indices tab"
  • [job] [logs] FTR Configs #28 / serverless examples UI Field formats example "before all" hook for "renders field formats example 1"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 565.8KB 565.8KB +5.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review September 28, 2023 12:03
@stratoula stratoula requested a review from a team as a code owner September 28, 2023 12:03
@stratoula stratoula added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Sep 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula stratoula changed the title [ES|QL] Resets selected comments when changing query [ES|QL] Resets selected columns when changing query Sep 28, 2023
davismcphee
davismcphee approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works as expected. Thanks and LGTM!

@stratoula stratoula merged commit d797846 into elastic:main Sep 29, 2023
13 checks passed
@jughosta jughosta mentioned this pull request Jun 11, 2024
Merged
2 tasks
stratoula added a commit that referenced this pull request Jun 18, 2024
@jughosta @stratoula @kertal
[Discover][ES|QL] Reset selected fields when modifying the ES|QL query (
250c729 
#185997)

- Closes #183961

## Summary

This PR updates the logic of resetting columns when modifying the ES|QL
query. The previous implementation was added in
#167492 and then changed in
#177241.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Matthias Wilhelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stratoula @kibana-ci @elasticmachine @davismcphee