[AO] use toMountPoint from react-kibana-mount for header menu portal (#…

…167126) Fixes #164366 ### Acceptance Criteria - use `toMountPoint` from `@kbn/react-kibana-mount` for [kibana/x-pack/plugins/observability/public/pages/overview/components/header_menu/header_menu_portal.tsx](https://github.com/elastic/kibana/blob/fcf838e1f389cae6fcaeb9f7bce713123a01c939/x-pack/plugins/observability/public/pages/overview/components/header_menu/header_menu_portal.tsx#L10) --------- Co-authored-by: Kibana Machine <[email protected]>
elastic · Sep 28, 2023 · ba31c76 · ba31c76
1 parent 8e6101e
commit ba31c76
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/...plugins/observability/public/pages/overview/components/header_menu/header_menu_portal.tsx b/...plugins/observability/public/pages/overview/components/header_menu/header_menu_portal.tsx
@@ -7,9 +7,9 @@
 
 import React, { ReactNode, useEffect, useMemo } from 'react';
 import { createHtmlPortalNode, InPortal, OutPortal } from 'react-reverse-portal';
-import { toMountPoint } from '@kbn/kibana-react-plugin/public';
+import { toMountPoint } from '@kbn/react-kibana-mount';
 import { AppMountParameters } from '@kbn/core/public';
-
+import { useKibana } from '../../../../utils/kibana_react';
 export interface HeaderMenuPortalProps {
   children: ReactNode;
   setHeaderActionMenu: AppMountParameters['setHeaderActionMenu'];
@@ -22,19 +22,22 @@ export default function HeaderMenuPortal({
   setHeaderActionMenu,
   theme$,
 }: HeaderMenuPortalProps) {
+  const { i18n } = useKibana().services;
   const portalNode = useMemo(() => createHtmlPortalNode(), []);
 
   useEffect(() => {
     setHeaderActionMenu((element) => {
-      const mount = toMountPoint(<OutPortal node={portalNode} />, { theme$ });
+      const mount = toMountPoint(<OutPortal node={portalNode} />, {
+        ...{ theme: { theme$ }, i18n },
+      });
       return mount(element);
     });
 
     return () => {
       portalNode.unmount();
       setHeaderActionMenu(undefined);
     };
-  }, [portalNode, setHeaderActionMenu, theme$]);
+  }, [portalNode, setHeaderActionMenu, i18n, theme$]);
 
   return <InPortal node={portalNode}>{children}</InPortal>;
 }
diff --git a/x-pack/plugins/observability/tsconfig.json b/x-pack/plugins/observability/tsconfig.json
@@ -87,6 +87,7 @@
     "@kbn/aiops-plugin",
     "@kbn/content-management-plugin",
     "@kbn/deeplinks-observability",
+    "@kbn/react-kibana-mount",
     "@kbn/react-kibana-context-theme"
   ],
   "exclude": [