Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Switch to using toMountPoint from @kbn/react-kibana-mount for header menu portal #164366

Closed
simianhacker opened this issue Aug 21, 2023 · 1 comment · Fixed by #167126
Closed

[AO] Switch to using toMountPoint from @kbn/react-kibana-mount for header menu portal #164366

simianhacker opened this issue Aug 21, 2023 · 1 comment · Fixed by #167126
Assignees
@mgiota
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" technical debt Improvement of the software architecture and operational architecture v8.11.0

Comments

@simianhacker
Copy link
Member

simianhacker commented Aug 21, 2023 •
edited
Loading

We need to switch to using toMountPoint from @kbn/react-kibana-mount for the following file:

kibana/x-pack/plugins/observability/public/pages/overview/components/header_menu/header_menu_portal.tsx

Line 10 in fcf838e

import { toMountPoint } from '@kbn/kibana-react-plugin/public';

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2023
@simianhacker simianhacker added technical debt Improvement of the software architecture and operational architecture Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Aug 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 21, 2023
@mgiota mgiota self-assigned this Sep 25, 2023
@mgiota mgiota mentioned this issue Sep 25, 2023
Merged
@mgiota mgiota added the v8.11.0 label Sep 26, 2023
mgiota added a commit that referenced this issue Sep 28, 2023
@mgiota @kibanamachine
[AO] use toMountPoint from react-kibana-mount for header menu portal (#…
ba31c76 
…167126)

Fixes #164366

### Acceptance Criteria
- use `toMountPoint` from `@kbn/react-kibana-mount` for
[kibana/x-pack/plugins/observability/public/pages/overview/components/header_menu/header_menu_portal.tsx](https://github.com/elastic/kibana/blob/fcf838e1f389cae6fcaeb9f7bce713123a01c939/x-pack/plugins/observability/public/pages/overview/components/header_menu/header_menu_portal.tsx#L10)

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgiota mgiota

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" technical debt Improvement of the software architecture and operational architecture v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AO] use toMountPoint from react-kibana-mount for header menu portal mgiota/kibana
3 participants
@simianhacker @mgiota @elasticmachine