-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AO] use toMountPoint from react-kibana-mount for header menu portal #167126
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
6248ab9
to
5c4e305
Compare
5c4e305
to
9b793a7
Compare
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@simianhacker This is probably out of scope of this PR, but while working on this one, I noticed there is an observability shared
However, the shared plugin still uses |
I'm not familiar with the |
@simianhacker Yes I could do this. Here are the places that make use of the shared |
91eb2e6
to
233dd72
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @mgiota |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #164366
Acceptance Criteria
toMountPoint
from@kbn/react-kibana-mount
for kibana/x-pack/plugins/observability/public/pages/overview/components/header_menu/header_menu_portal.tsx