Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] use toMountPoint from react-kibana-mount for header menu portal #167126

Merged
merged 7 commits into from
Sep 28, 2023

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Sep 25, 2023

Fixes #164366

Acceptance Criteria

@mgiota mgiota self-assigned this Sep 25, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mgiota mgiota added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Sep 25, 2023
@mgiota mgiota added v8.11.0 technical debt Improvement of the software architecture and operational architecture labels Sep 25, 2023
@mgiota mgiota marked this pull request as ready for review September 25, 2023 22:17
@mgiota mgiota requested a review from a team as a code owner September 25, 2023 22:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@mgiota mgiota added the release_note:skip Skip the PR/issue when compiling release notes label Sep 25, 2023
@mgiota
Copy link
Contributor Author

mgiota commented Sep 25, 2023

@elasticmachine merge upstream

@mgiota
Copy link
Contributor Author

mgiota commented Sep 26, 2023

@elasticmachine merge upstream

@mgiota
Copy link
Contributor Author

mgiota commented Sep 26, 2023

@elasticmachine merge upstream

@mgiota
Copy link
Contributor Author

mgiota commented Sep 26, 2023

@simianhacker This is probably out of scope of this PR, but while working on this one, I noticed there is an observability shared HeaderMenuPortal component, which we could eventually use at some point.

import { HeaderMenuPortal } from '@kbn/observability-shared-plugin/public';

However, the shared plugin still uses toMountPoint from the old path '@kbn/kibana-react-plugin/public'. I see observability-ui team is responsible for making changes under observability-shared-plugin, right? Once they update using the proper toMountPoint, we could reuse the shared HeaderPortalMenu. Shall I create a ticket for our team?

@simianhacker
Copy link
Member

I see observability-ui team is responsible for making changes under observability-shared-plugin, right? Once they update using the proper toMountPoint, we could reuse the shared HeaderPortalMenu. Shall I create a ticket for our team?

I'm not familiar with the HeaderPortalMenu... maybe we should also update the path in that component. Then expore using it, if that makes sense.

@simianhacker simianhacker self-requested a review September 27, 2023 15:38
@mgiota
Copy link
Contributor Author

mgiota commented Sep 27, 2023

@simianhacker Yes I could do this. Here are the places that make use of the shared HeaderMenuPortal.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 457 463 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB +717.0B
Unknown metric groups

References to deprecated APIs

id before after diff
observability 40 38 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@mgiota mgiota merged commit ba31c76 into elastic:main Sep 28, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" technical debt Improvement of the software architecture and operational architecture v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AO] Switch to using toMountPoint from @kbn/react-kibana-mount for header menu portal
6 participants