[Discover][ES|QL] Reset selected fields when modifying the ES|QL query #185997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:fix
backport:skip
|
/ci |
jughosta
commented
Jun 12, 2024
| expect(await dataGrid.getHeaderFields()).to.eql(['@timestamp', 'Document']); | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
@stratoula I made it closer to what we had in 8.13 and would be great if you could verify the use cases which are mentioned in these tests. Are they working as expected now or more modifications are needed?
There was a problem hiding this comment.
Thanx Jul, I will check first thing in the morning
There was a problem hiding this comment.
Yes they are correct 👍 I tested it also locally, everything works as expected
|
/ci |
|
/ci |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Ikuni17
approved these changes
Jun 14, 2024
kertal
reviewed
Jun 17, 2024
src/plugins/discover/public/application/main/hooks/use_esql_mode.test.tsx
Outdated
Show resolved
Hide resolved
kertal
reviewed
Jun 17, 2024
src/plugins/discover/public/application/main/hooks/use_esql_mode.test.tsx
Outdated
Show resolved
Hide resolved
kertal
reviewed
Jun 17, 2024
src/plugins/discover/public/application/main/hooks/use_esql_mode.ts
Outdated
Show resolved
Hide resolved
…de.test.tsx Co-authored-by: Matthias Wilhelm <[email protected]>
…de.test.tsx Co-authored-by: Matthias Wilhelm <[email protected]>
jughosta
commented
Jun 17, 2024
src/plugins/discover/public/application/main/hooks/use_esql_mode.ts
Outdated
Show resolved
Hide resolved
kertal
approved these changes
Jun 17, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
stratoula
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the logic of resetting columns when modifying the ES|QL query. The previous implementation was added in #167492 and then changed in #177241.
Checklist