Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline for serverless kibana release #165009

Merged
merged 10 commits into from
Aug 31, 2023

Conversation

imkarrer
Copy link
Contributor

@imkarrer imkarrer commented Aug 28, 2023

Summary

Adds a pipeline that will trigger the promotion and QG for kibana through qa -> staging -> production whenever the tag which matches the regex is created.

Sibling PR here that defines main/gen/gpctl/kibana/tagged-release.yaml

The meat of the PR is the regex.

@imkarrer imkarrer requested review from a team as code owners August 28, 2023 16:23
@imkarrer imkarrer added the release_note:skip Skip the PR/issue when compiling release notes label Aug 28, 2023
catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
@imkarrer
Copy link
Contributor Author

imkarrer commented Aug 29, 2023

https://github.com/elastic/serverless-gitops/pull/661 has merged, so the gpctl config reference will be valid when this merges.

catalog-info.yaml Outdated Show resolved Hide resolved
@delanni
Copy link
Contributor

delanni commented Aug 30, 2023

Could we also change the references from kibana-release to kibana-serverless-release (in the pipeline name and the pipeline file's name)? I'd like to avoid confusion, as there are already plenty of release related jobs.

catalog-info.yaml Outdated Show resolved Hide resolved
Co-authored-by: Alex Szabo <[email protected]>
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the tests are failing. But I can't see why it's related to this PR. So from my point of view it looks good 👍

@delanni
Copy link
Contributor

delanni commented Aug 30, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@imkarrer imkarrer merged commit 581b7f4 into elastic:main Aug 31, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 31, 2023
delanni added a commit that referenced this pull request Sep 6, 2023
## Summary
Sets up quality gate triggering in Kibana. The tests are mostly
triggering external pipelines and relying on their results. Here's an
example run:
https://buildkite.com/elastic/kibana-tests/builds/28#job-018a69a6-c860-405e-ab2b-bce2aed07df3

According to [this
doc](https://docs.google.com/document/d/15rx2Z-soL20An0nBUcXX0o_HHf1OU_IgrHXgz20NndI/edit)
many of the quality gates are really required for the QA->Staging
promotion step.

Most of the tests are in the QA stage: 
 - [fleet smoke tests](https://buildkite.com/elastic/fleet-smoke-tests)
- ~~[QAF RAC load
tests](https://buildkite.com/elastic/appex-qa-rac-alert-load)~~ Removed,
see #165346 (comment)
- [QAF serverless
tests](https://buildkite.com/elastic/appex-qa-kibana-serverless-ftr-tests)
- [control plane QA smoke
tests](https://buildkite.com/elastic/ess-k8s-qa-e2e-tests-daily)
- [security solution
tests](.buildkite/scripts/pipelines/security_solution_quality_gate/pipeline.sh)
+ manual check for confirming manual tests
 - Manual confirmation 👍

Staging has: 
- [control plane staging smoke
tests](https://buildkite.com/elastic/ess-k8s-staging-e2e-tests)
 - Manual confirmation 👍

Production has:
- [control plane production smoke
tests](https://buildkite.com/elastic/ess-k8s-production-e2e-tests)
 - Manual confirmation 👍

### Quirks
- ~~`SKIP_KIBANA_HOOKS=1` needs to be set from the triggering job~~
Split into #165597
- The pipeline can only be tested from the non-fork, `elastic/kibana`
repo's branches (because buildkite doesn't see forks' branches)
- Soft fails added, to not block the release pipeline in case we still
need to adjust/work on some unstable tests

Reference:
https://docs.google.com/document/d/15rx2Z-soL20An0nBUcXX0o_HHf1OU_IgrHXgz20NndI/edit
Depends on: #165009 
Closes: elastic/kibana-operations#10

---------

Co-authored-by: Tiago Costa <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants