Add GitHub Action Workflow: create-deploy-tag #165213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
release_note:skip
delanni
approved these changes
Aug 30, 2023
watson
commented
Aug 30, 2023
| git tag ${TAG_NAME} ${COMMIT} | ||
| git push origin "refs/tags/${TAG_NAME}" | ||
| - if: always() | ||
| uses: elastic/apm-pipeline-library/.github/actions/notify-build-status@current |
There was a problem hiding this comment.
Btw, I just copied this from the APM team and is using their notify script. I'm not sure if we have a more Elastic-wide generic script to do the same? It seems odd to me that APM has a custom one?
jbudz
reviewed
Aug 30, 2023
| } || true | ||
| - name: Verify branch | ||
| run: | | ||
| if [[ "${GITHUB_REF}" != "refs/heads/main" ]]; then |
There was a problem hiding this comment.
We probably want to skip this on forks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be used by the Kibana Release Manager when kicking off the promotion of a new Kibana Serverless release into our Serverless QA environment (see #165009 for details).
This GitHub Action workflow is inspired by this. The main difference is that it has an input field to allow tagging something other than
HEADonmain.Note to reviewers
I've tried to test this locally using act, but ran into some permission issues in the "Create tag" step. However, the other steps completed fine. I'm not sure if there's a good way to verify this before merging. Alternatively we can merge, test and make follow-up PR's accordingly.