[Ops] Skip buildkite hooks for non kibana jobs #165597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
approved these changes
Sep 4, 2023
|
@brianseeders I don't think this change will have unintended consequences but can you think about any? |
If you're still running jobs on static workers (mac or hetzner), those probably don't have this env var set. Might be better to use something that positively identifies the new CI-systems environment rather than the absence of the kibana environment |
|
Good point @brianseeders - do you think something like matching on the agent's name starting with |
…ead of the agent manager
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.11.0
backport:skip
delanni
added a commit
that referenced
this pull request
Sep 6, 2023
## Summary Sets up quality gate triggering in Kibana. The tests are mostly triggering external pipelines and relying on their results. Here's an example run: https://buildkite.com/elastic/kibana-tests/builds/28#job-018a69a6-c860-405e-ab2b-bce2aed07df3 According to [this doc](https://docs.google.com/document/d/15rx2Z-soL20An0nBUcXX0o_HHf1OU_IgrHXgz20NndI/edit) many of the quality gates are really required for the QA->Staging promotion step. Most of the tests are in the QA stage: - [fleet smoke tests](https://buildkite.com/elastic/fleet-smoke-tests) - ~~[QAF RAC load tests](https://buildkite.com/elastic/appex-qa-rac-alert-load)~~ Removed, see #165346 (comment) - [QAF serverless tests](https://buildkite.com/elastic/appex-qa-kibana-serverless-ftr-tests) - [control plane QA smoke tests](https://buildkite.com/elastic/ess-k8s-qa-e2e-tests-daily) - [security solution tests](.buildkite/scripts/pipelines/security_solution_quality_gate/pipeline.sh) + manual check for confirming manual tests - Manual confirmation 👍 Staging has: - [control plane staging smoke tests](https://buildkite.com/elastic/ess-k8s-staging-e2e-tests) - Manual confirmation 👍 Production has: - [control plane production smoke tests](https://buildkite.com/elastic/ess-k8s-production-e2e-tests) - Manual confirmation 👍 ### Quirks - ~~`SKIP_KIBANA_HOOKS=1` needs to be set from the triggering job~~ Split into #165597 - The pipeline can only be tested from the non-fork, `elastic/kibana` repo's branches (because buildkite doesn't see forks' branches) - Soft fails added, to not block the release pipeline in case we still need to adjust/work on some unstable tests Reference: https://docs.google.com/document/d/15rx2Z-soL20An0nBUcXX0o_HHf1OU_IgrHXgz20NndI/edit Depends on: #165009 Closes: elastic/kibana-operations#10 --------- Co-authored-by: Tiago Costa <[email protected]> Co-authored-by: Thomas Watson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kibana's build jobs work on a different subset of executors than the buildkite pipelines defined in
catalog-info.yaml.The former jobs require a set of
pre_command/post_commandsteps to prepare the jobs for building/testing kibana.The latter don't have access rights to certain vault secrets (and possibly other missing config from the Kibana world), but for now, they're also not building Kibana, they just trigger other jobs, so we can just skip the problematic hooks.
A probably good indicator I found for deciding whether we need the kibana-relatedpre_commandis theBUILDKITE_AGENT_META_DATA_AGENT_MANAGERflag, that's set to"kibana"in the case of the kibana executors.We can try to match on the agent names for the CI-systems agents. They seem to be starting with
bk-agent.This should allow for the kibana-tests job to run.
Split from: #165346