-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data / search session] BWCA all the routes #158981
[data / search session] BWCA all the routes #158981
Conversation
So CI doesn't overwrite, these are failing - [job] [logs] Jest Tests #9 / registerSessionRoutes cancel calls cancelSession with id |
…finition Fix session tests
…attkime/kibana into search_session_better_route_definition
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, and I tested search session functionality locally in Discover and the management screen, and all endpoints seem to be working as expected. LGTM
}, | ||
}, | ||
async (context, request, res) => { | ||
const { id } = request.params; | ||
const { expires } = request.body; | ||
try { | ||
const searchContext = await context.search; | ||
const response = await searchContext.extendSession(id, new Date(expires)); | ||
await searchContext.extendSession(id, new Date(expires)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why the return type here changed. Were we just not using it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @mattkime |
Summary
All routes
Closes #158944