fix update route

elastic · Jun 13, 2023 · a128635 · a128635
1 parent 3e0521a
commit a128635
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 5 deletions.
diff --git a/src/plugins/data/server/search/routes/response_schema.ts b/src/plugins/data/server/search/routes/response_schema.ts
@@ -53,3 +53,20 @@ export const searchSessionsFindSchema = schema.object({
   saved_objects: schema.arrayOf(searchSessionSchema),
   statuses: schema.recordOf(schema.string(), searchSessionStatusSchema),
 });
+
+const referencesSchema = schema.arrayOf(
+  schema.object({ id: schema.string(), type: schema.string(), name: schema.string() })
+);
+
+export const searchSessionsUpdateSchema = schema.object({
+  id: schema.string(),
+  type: schema.string(),
+  updated_at: schema.maybe(schema.string()),
+  version: schema.maybe(schema.string()),
+  namespaces: schema.maybe(schema.arrayOf(schema.string())),
+  references: schema.maybe(referencesSchema),
+  attributes: schema.object({
+    name: schema.maybe(schema.string()),
+    expires: schema.maybe(schema.string()),
+  }),
+});
diff --git a/src/plugins/data/server/search/routes/response_types.ts b/src/plugins/data/server/search/routes/response_types.ts
@@ -50,3 +50,16 @@ export interface SearchSessionsFindRestResponse {
    */
   statuses: Record<string, SearchSessionStatusRestResponse>;
 }
+
+export interface SearchSessionsUpdateRestResponse {
+  id: string;
+  type: string;
+  updated_at?: string;
+  version?: string;
+  namespaces?: string[];
+  references?: Array<{ id: string; type: string; name: string }>;
+  attributes: {
+    name?: string;
+    expires?: string;
+  };
+}
diff --git a/src/plugins/data/server/search/routes/session.ts b/src/plugins/data/server/search/routes/session.ts
@@ -14,11 +14,13 @@ import {
   SearchSessionRestResponse,
   SearchSessionStatusRestResponse,
   SearchSessionsFindRestResponse,
+  SearchSessionsUpdateRestResponse,
 } from './response_types';
 import {
   searchSessionSchema,
   searchSessionStatusSchema,
   searchSessionsFindSchema,
+  searchSessionsUpdateSchema,
 } from './response_schema';
 
 const STORE_SEARCH_SESSIONS_ROLE_TAG = `access:store_search_session`;
@@ -262,17 +264,22 @@ export function registerSessionRoutes(router: DataPluginRouter, logger: Logger):
             expires: schema.maybe(schema.string()),
           }),
         },
+        response: {
+          200: {
+            body: searchSessionsUpdateSchema,
+          },
+        },
       },
     },
     async (context, request, res) => {
-      console.log('put /{id}');
       const { id } = request.params;
       const { name, expires } = request.body;
       try {
         const searchContext = await context.search;
-        // todo
-        const response = await searchContext.updateSession(id, { name, expires });
-
+        const response: SearchSessionsUpdateRestResponse = await searchContext.updateSession(id, {
+          name,
+          expires,
+        });
         return res.ok({
           body: response,
         });
@@ -298,7 +305,6 @@ export function registerSessionRoutes(router: DataPluginRouter, logger: Logger):
       },
     },
     async (context, request, res) => {
-      console.log('post /{id}/_extend');
       const { id } = request.params;
       const { expires } = request.body;
       try {