Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search-session] Routes must satisfy bwca #158944

Closed
kertal opened this issue Jun 2, 2023 · 2 comments · Fixed by #158981
Closed

[search-session] Routes must satisfy bwca #158944

kertal opened this issue Jun 2, 2023 · 2 comments · Fixed by #158981
Assignees
@mattkime
Labels
chore Feature:Search Sessions Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Jun 2, 2023

Internal search-session routes must be backward compliant, those are

  • /internal/session
  • /internal/session/{id}
  • /internal/session/{id}/status
  • /internal/session/_find
  • /internal/session/{id}
  • /internal/session/{id}/cancel
  • /internal/session/{id}
  • /internal/session/{id}/_extend

Code:

savedObjectsClient

Part of #157046
@kertal kertal added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Jun 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the chore label Jun 2, 2023
@kertal
Copy link
Member Author

kertal commented Jun 2, 2023

@thomasneirynck FYI, a new one

@mattkime mattkime mentioned this issue Jun 13, 2023
Merged
mattkime added a commit that referenced this issue Jun 16, 2023
@mattkime @lukasolson
[data / search session] BWCA all the routes (#158981)
5c5add2 
### Summary

All routes
- Use versioned router
- Validate responses
- All responses are typed with response types, separate from internal
api types. This is to help prevent unacknowledged changes to the api.

Closes #158944

---------

Co-authored-by: Lukas Olson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
chore Feature:Search Sessions Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[data / search session] BWCA all the routes mattkime/kibana
3 participants
@mattkime @kertal @elasticmachine