-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heatmap small multiples #154434
Heatmap small multiples #154434
Conversation
@@ -212,7 +212,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
}); | |||
|
|||
it('area, bar and heatmap charts', async () => { | |||
await dashboardExpect.seriesElementCount(2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ I am testing the x labels here instead of the y labels as there is this bug on std deviation #154523
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presentation team functional test changes LGTM! Code only review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still reviewing code and testing it out locally but have a few comments in the meantime.
src/plugins/chart_expressions/expression_heatmap/public/components/chart_split.tsx
Outdated
Show resolved
Hide resolved
src/plugins/chart_expressions/expression_heatmap/public/components/chart_split.tsx
Show resolved
Hide resolved
src/plugins/chart_expressions/expression_heatmap/public/components/heatmap_component.tsx
Outdated
Show resolved
Hide resolved
…ents/chart_split.tsx Co-authored-by: Nick Partridge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again locally and all looks good to me! 🎉
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Enables split chart in agg based heatmaps (small multiples) and makes the EC implementation the default. It also marks the advanced setting that changes the implementation as deprecated.
Checklist
Delete any items that are not applicable to this PR.