Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aggbased][Heatmap] Standard deviation metric is not rendered correctly in the EC implementation #154523

Closed
stratoula opened this issue Apr 6, 2023 · 7 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Heatmap Heatmap visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Kibana version:
When we added the heatmap EC implementation

Describe the bug:
Create a heatmap with standard deviation. Only the Lower bound is visible and not the upper

With EC
image

With vislib
image

@stratoula stratoula added bug Fixes for quality problems that affect the customer experience Feature:Heatmap Heatmap visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Apr 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula
Copy link
Contributor Author

But I am not sure how this should work on a heatmap. On vislib is like you have 2 heatmaps one with lower deviation as value and the other as the upper. Possibly with small multiples?

cc @markov00

@stratoula stratoula added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Apr 6, 2023
@markov00
Copy link
Member

markov00 commented Apr 6, 2023

the vislib data implementation is exposing 2 series, one for the low bounds and one for the upper bounds, but lens only return 1 value (I'm looking at the Inspect -> table). Both aggregations are the same but the resulting table is different.
We don't need to have a small multiple, but just 2 series to render

@stratoula
Copy link
Contributor Author

stratoula commented Apr 6, 2023

@markov00 the data exist for the upper bounds too we just dont expose them (on agg based heatmap

Can I have 2 valueAccessors on a heatmap in EC?

@markov00
Copy link
Member

@stratoula actually no, your data should be formatted as the following:

X Y VALUE
timestamp UpperSeries Value
timestamp LowerSeries Value

With a data transformation like the following:

const data = table.map(d => [d.x, "upper", d.upper]).concat(table.map(d => [d.x, "lower", d.lower]))

@stratoula
Copy link
Contributor Author

Got it Marco! Thanx!

@stratoula stratoula added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Apr 13, 2023
@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 19, 2023
@stratoula
Copy link
Contributor Author

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@stratoula stratoula closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Heatmap Heatmap visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants