Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug brushing Heatmap with small multiples #2024

Closed
3 tasks done
nickofthyme opened this issue Apr 13, 2023 · 0 comments · Fixed by #2028
Closed
3 tasks done

Bug brushing Heatmap with small multiples #2024

nickofthyme opened this issue Apr 13, 2023 · 0 comments · Fixed by #2028
Assignees
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue kibana cross issue Has a Kibana issue counterpart :small multiples Small multiples/trellising related issues

Comments

@nickofthyme
Copy link
Collaborator

Describe the issue

When using the Heatmap with SmallMultiples, the brush incorrectly determines the selected cell range.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/brave-maria-19rofp?file=/src/App.tsx
  2. Brush on the first panel in the first column of cells
  3. Notice the correct brushing range is highlighted
  4. Brush the last column in the first panel
  5. Notice the highlighter brush selection is on the second panel

Expected behaviour

Correct range is highlighted

Screenshots

Screen Recording 2023-04-13 at 04 09 05 PM

Version (please complete the following information):

  • Elastic Charts: main

Additional context
There was an issue with this when developing that selected the actual column plus 1 due to the use of bisectLeft function. But that was supposedly fixed and may be related or not.

Kibana Cross Issues
Needed for elastic/kibana#154434

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • Every related Kibana issue is listed under Kibana Cross Issues list and the kibana cross issue tag is applied
@nickofthyme nickofthyme added bug Something isn't working kibana cross issue Has a Kibana issue counterpart :heatmap Heatmap/Swimlane chart related issue :small multiples Small multiples/trellising related issues labels Apr 13, 2023
@nickofthyme nickofthyme self-assigned this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue kibana cross issue Has a Kibana issue counterpart :small multiples Small multiples/trellising related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant