Update dependency @elastic/charts to v55 (main) #153889

renovate · 2023-03-28T17:06:24Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@elastic/charts	`54.0.0` -> `55.0.0`

Release Notes

elastic/elastic-charts

`v55.0.0`

Compare Source

Bug Fixes

docs: lint and fix EUI breaking changes (0d14194)

Features

heatmap: small multiples (#1933) (690f568)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

renovate · 2023-04-03T10:30:16Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

nickofthyme · 2023-04-04T17:19:38Z

This PR has a breaking change related to heatmap settings. Namely...

@@ -1424,25 +1424,13 @@ export interface HeatmapStyle {
     grid: {
-        cellWidth: {
-            min: Pixels;
-            max: Pixels | 'fill';
-        };
-        cellHeight: {
-            min: Pixels;
-            max: Pixels | 'fill';
-        };
         stroke: {
             color: string;
             width: number;
         };
     };
-    maxColumnWidth: Pixels;
     maxLegendHeight?: number;
-    maxRowHeight: Pixels;

The maxColumnWidth and maxRowHeight values were not being used anywhere thus have no impact to any kibana usage.

The grid.cellWidth and grid.cellHeight properties were removed to prevent inaccessible pagination, see full rational in the description details of elastic/elastic-charts#1933.

I've testing ML swimlane compared with 8.7 and don't see any issues pertaining to removal of these grid constraints.

elasticmachine · 2023-04-04T17:19:50Z

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

nickofthyme · 2023-04-04T20:09:32Z

src/plugins/chart_expressions/expression_heatmap/public/components/heatmap_component.tsx

-          cellHeight: {
-            max: 'fill',
-            min: 1,
-          },


No effect here, this would have filled rows to available space anyways.

nickofthyme · 2023-04-04T20:11:12Z

x-pack/plugins/ml/public/application/explorer/swimlane_container.tsx

-          cellHeight: {
-            min: CELL_HEIGHT,
-            max: CELL_HEIGHT,
-          },


Since the overall chart height is computed based on the desired row height, this would have had no effect. Nor does the UI change from this removal looking at the Anomaly Explorer in ml between this PR and 8.7.

nickofthyme · 2023-04-04T20:12:40Z

...blic/apps/synthetics/components/monitor_details/monitor_status/monitor_status_chart_theme.ts

-      cellHeight: {
-        min: 20,
-      },


Unable to verify this change, @elastic/uptime could you verify this chart has no regressions from this change?

cc @awahab07

Looks good.

nickofthyme · 2023-04-04T20:13:02Z

...blic/apps/synthetics/components/monitor_details/monitor_status/monitor_status_chart_theme.ts

-    maxRowHeight: 30,
-    maxColumnWidth: CHART_CELL_WIDTH,


Not used in charts so no change.

elasticmachine · 2023-04-04T20:13:16Z

Pinging @elastic/uptime (Team:uptime)

kibana-ci · 2023-04-05T08:57:13Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 1edf1cd

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #15 / context app context filters filter for presence should be addable via expanded data grid rows
[job] [logs] FTR Configs #29 / dashboard app - group 1 Changing field formatter to Url applied on dashboard

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionHeatmap`	89.2KB	89.2KB	-30.0B
`ml`	3.4MB	3.4MB	-27.0B
`synthetics`	1.4MB	1.4MB	-54.0B
total			-111.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-npmDll`	5.4MB	5.4MB	+6.9KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	432	435	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	512	515	+3

History

💛 Build #117816 was flaky 9161d3e
💚 Build #117686 succeeded b8a84fb
💔 Build #117527 failed f0f8c22
💔 Build #117506 failed 8e4bdda
💔 Build #117489 failed 86a2ef0
💔 Build #117321 failed 5c64927

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

darnautov

ML changes tested and LGTM

nickofthyme · 2023-04-05T15:03:18Z

@elasticmachine run elasticsearch-ci/docs

awahab07

LGTM!

awahab07 · 2023-04-06T09:51:53Z

...blic/apps/synthetics/components/monitor_details/monitor_status/monitor_status_chart_theme.ts

-      cellHeight: {
-        min: 20,
-      },


Looks good.

stratoula

Visualizations changes LGTM, I am working on a draft PR which enables small multiples in heatmap and it works fine.

Update dependency @elastic/charts to v55

0af960c

renovate bot added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 28, 2023

fix type breaking changes

5c64927

nickofthyme and others added 4 commits April 3, 2023 09:51

Merge branch 'main' into renovate/main-@elasticcharts

86a2ef0

fix: remove all heatmap grid height/width constraints

8e4bdda

fix: add back constant variable

f0f8c22

Merge branch 'main' into renovate/main-@elasticcharts

b8a84fb

nickofthyme marked this pull request as ready for review April 4, 2023 17:19

nickofthyme requested review from a team as code owners April 4, 2023 17:19

nickofthyme reviewed Apr 4, 2023

View reviewed changes

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 4, 2023

nickofthyme and others added 2 commits April 4, 2023 13:13

Merge branch 'main' into renovate/main-@elasticcharts

9161d3e

Merge branch 'main' into renovate/main-@elasticcharts

1edf1cd

darnautov approved these changes Apr 5, 2023

View reviewed changes

awahab07 approved these changes Apr 6, 2023

View reviewed changes

stratoula approved these changes Apr 6, 2023

View reviewed changes

stratoula merged commit b8409c9 into main Apr 6, 2023

stratoula deleted the renovate/main-@elasticcharts branch April 6, 2023 10:11

kibanamachine added the v8.8.0 label Apr 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependency @elastic/charts to v55 (main) #153889

Update dependency @elastic/charts to v55 (main) #153889

renovate bot commented Mar 28, 2023

renovate bot commented Apr 3, 2023

nickofthyme commented Apr 4, 2023

elasticmachine commented Apr 4, 2023

nickofthyme Apr 4, 2023

nickofthyme Apr 4, 2023 •

edited

Loading

nickofthyme Apr 4, 2023

shahzad31 Apr 6, 2023

awahab07 Apr 6, 2023

nickofthyme Apr 4, 2023

elasticmachine commented Apr 4, 2023

kibana-ci commented Apr 5, 2023

ESLint disabled line counts

Total ESLint disabled count

darnautov left a comment

nickofthyme commented Apr 5, 2023

awahab07 left a comment

awahab07 Apr 6, 2023

stratoula left a comment

Update dependency @elastic/charts to v55 (main) #153889

Update dependency @elastic/charts to v55 (main) #153889

Conversation

renovate bot commented Mar 28, 2023

Release Notes

v55.0.0

Bug Fixes

Features

Configuration

renovate bot commented Apr 3, 2023

Edited/Blocked Notification

nickofthyme commented Apr 4, 2023

elasticmachine commented Apr 4, 2023

nickofthyme Apr 4, 2023

Choose a reason for hiding this comment

nickofthyme Apr 4, 2023 • edited Loading

Choose a reason for hiding this comment

nickofthyme Apr 4, 2023

Choose a reason for hiding this comment

shahzad31 Apr 6, 2023

Choose a reason for hiding this comment

awahab07 Apr 6, 2023

Choose a reason for hiding this comment

nickofthyme Apr 4, 2023

Choose a reason for hiding this comment

elasticmachine commented Apr 4, 2023

kibana-ci commented Apr 5, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

darnautov left a comment

Choose a reason for hiding this comment

nickofthyme commented Apr 5, 2023

awahab07 left a comment

Choose a reason for hiding this comment

awahab07 Apr 6, 2023

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

`v55.0.0`

nickofthyme Apr 4, 2023 •

edited

Loading