-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(heatmap): small multiples #1933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
wip
work in progress
:heatmap
Heatmap/Swimlane chart related issue
:small multiples
Small multiples/trellising related issues
labels
Jan 12, 2023
- move shared sm logic to common - move sm scales to internal state - colocate panel utils with common sm logic - merge/simplify common types
- add heatmap sm example - update grid sm story knobs
nickofthyme
force-pushed
the
heatmap-sm
branch
from
January 24, 2023 07:43
2d00f36
to
bdee7d1
Compare
- Add missing files - Update moved file path locations
nickofthyme
commented
Feb 8, 2023
- previously providing a single input would yeild a zero-width brush area - this change attempts to find the next x interval value for a non-zero-width brush area
buildkite update screenshots |
buildkite test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:heatmap
Heatmap/Swimlane chart related issue
:small multiples
Small multiples/trellising related issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for small multiples for heatmap chart types. View demo story here.
Screen.Recording.2023-03-07.at.03.10.43.PM.mp4
BREAKING CHANGES
Removed unused properties
maxColumnWidth
andmaxRowHeight
underHeatmapStyle
. Also removed grid height and width constraints (i.e.cellWidth
andcellHeight
) in favor of filled rendering and pagination driven by data from the consumer side.Details
Rational behind breaking changes -- The heatmap grid constraints were initially used to constrain the height on all rows or widths on all columns. This creates a problem as the overall chart size is not responsive to these grid constraints and would truncate the dataset as needed to respect the grid constraints. So in some cases you could have a heatmap with 20 rows of data but only say 10 would be visible, and there was no mechanism internally to charts to communicate the page nor page size to the chart consumer, thus creating an inaccessible and otherwise unknown truncation of the dataset.
Consumers in kibana using these constraints are computing the necessary overall chart height to set the rows to a constant value. Doing so would size the rows adequately with a simple
fill
height without the need for manual constraints.Additionally, all other charts are sized based on the top-level container size to fill the available space with no sizing based on internal values or child element sizes.
The
maxColumnWidth
andmaxRowHeight
values were not being used anywhere thus have no impact to any kibana usage.TODOS
Future tasks
verticalPanelPadding.outer
andhorizontalPanelPadding.outer
. Should be consistent across all small multiples implementations. Better support forouter
padding forSmallMultiplesStyle
#1992theme.heatmap.grid.stroke.width
for interactions and dimensioning. Improve support fortheme.heatmap.grid.stroke.width
on small multiples #1993Issues
close #1484
Checklist
:xy
,:partition
):interactions
,:axis
)closes #123
,fixes #123
)packages/charts/src/index.ts
dark
,light
,eui-dark
&eui-light