Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v55 (main) #153889

Merged
merged 8 commits into from
Apr 6, 2023
Merged

Update dependency @elastic/charts to v55 (main) #153889

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0af960c
Update dependency @elastic/charts to v55
renovate[bot] Mar 28, 2023
5c64927
fix type breaking changes
markov00 Apr 3, 2023
86a2ef0
Merge branch 'main' into renovate/main-@elasticcharts
nickofthyme Apr 3, 2023
8e4bdda
fix: remove all heatmap grid height/width constraints
nickofthyme Apr 3, 2023
f0f8c22
fix: add back constant variable
nickofthyme Apr 3, 2023
b8a84fb
Merge branch 'main' into renovate/main-@elasticcharts
markov00 Apr 4, 2023
9161d3e
Merge branch 'main' into renovate/main-@elasticcharts
nickofthyme Apr 4, 2023
1edf1cd
Merge branch 'main' into renovate/main-@elasticcharts
stratoula Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"@dnd-kit/utilities": "^2.0.0",
"@elastic/apm-rum": "^5.12.0",
"@elastic/apm-rum-react": "^1.4.2",
"@elastic/charts": "54.0.0",
"@elastic/charts": "55.0.0",
"@elastic/datemath": "5.0.3",
"@elastic/elasticsearch": "npm:@elastic/[email protected]",
"@elastic/ems-client": "8.4.0",
Expand Down
4 changes: 0 additions & 4 deletions src/plugins/chart_expressions/expression_heatmap/public/components/heatmap_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,10 +524,6 @@ export const HeatmapComponent: FC<HeatmapRenderProps> = memo(
chartTheme.axes?.gridLine?.horizontal?.stroke ??
'#D3DAE6',
},
cellHeight: {
max: 'fill',
min: 1,
},
Comment on lines -527 to -530
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No effect here, this would have filled rows to available space anyways.

},
cell: {
maxWidth: 'fill',
Expand Down
4 changes: 0 additions & 4 deletions x-pack/plugins/ml/public/application/explorer/swimlane_container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,6 @@ export const SwimlaneContainer: FC<SwimlaneProps> = ({
},
heatmap: {
grid: {
cellHeight: {
min: CELL_HEIGHT,
max: CELL_HEIGHT,
},
Comment on lines -294 to -297
Copy link
Contributor

@nickofthyme nickofthyme Apr 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the overall chart height is computed based on the desired row height, this would have had no effect. Nor does the UI change from this removal looking at the Anomaly Explorer in ml between this PR and 8.7.

stroke: {
width: BORDER_WIDTH,
color: euiTheme.euiBorderColor,
Expand Down
6 changes: 0 additions & 6 deletions ...c/apps/synthetics/components/monitor_details/monitor_status/monitor_status_chart_theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,18 @@

import { HeatmapStyle, RecursivePartial } from '@elastic/charts';
import { EuiThemeComputed } from '@elastic/eui';
import { CHART_CELL_WIDTH } from './monitor_status_data';

export function getMonitorStatusChartTheme(
euiTheme: EuiThemeComputed,
brushable: boolean
): RecursivePartial<HeatmapStyle> {
return {
grid: {
cellHeight: {
min: 20,
},
Comment on lines -18 to -20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to verify this change, @elastic/uptime could you verify this chart has no regressions from this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @awahab07

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

stroke: {
width: 0,
color: 'transparent',
},
},
maxRowHeight: 30,
maxColumnWidth: CHART_CELL_WIDTH,
Comment on lines -26 to -27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used in charts so no change.

cell: {
maxWidth: 'fill',
maxHeight: 3,
Expand Down
10 changes: 0 additions & 10 deletions ...ics/public/legacy_uptime/components/common/charts/__snapshots__/donut_chart.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,10 +1460,10 @@
dependencies:
object-hash "^1.3.0"

"@elastic/charts@54.0.0":
version "54.0.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-54.0.0.tgz#97e19c87c94d4282c12440e9d5703048232bc2b8"
integrity sha512-gyAgBrRKRg+QxaOluAy1tJXm3gv95IuZRL+/QMUR7tuAwqfD+Bi3eFUoqMhVJCRmhYJa2iDmLMjb7Mkb7HZJgw==
"@elastic/charts@55.0.0":
version "55.0.0"
resolved "https://registry.yarnpkg.com/@elastic/charts/-/charts-55.0.0.tgz#df9a4e9b0a84a613f103011d99f120cb528c4dc9"
integrity sha512-a4UIieTi04CPHxfwztDe36xoPFkp+I4tRPXWXobv/aG/zTd4AwruRyL981RiV2Tv8Mrc5jpCJFgfadNoPrL3pg==
dependencies:
"@popperjs/core" "^2.4.0"
bezier-easing "^2.1.0"
Expand Down