[AO] Fix time range filter in alerts table #153648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
release_note:fix
Team: Actionable Observability - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
CoenWarmer
reviewed
Mar 24, 2023
| @@ -12,7 +12,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => { | |||
| const observability = getService('observability'); | |||
| const retry = getService('retry'); | |||
|
|
|||
| describe('Observability alerts / Add to case', function () { | |||
| describe('Observability alerts / Add to case >', function () { | |||
There was a problem hiding this comment.
Love this, makes it way easier to find the corresponding test in failing ftr logs
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kdelemme
approved these changes
Mar 24, 2023
kibanamachine
added
v8.8.0
backport:skip
maryam-saeidi
added
backport:prev-minor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
maryam-saeidi
added a commit
to maryam-saeidi/kibana
that referenced
this pull request
Apr 25, 2023
Fixes elastic#153284 ## Summary This PR fixes the time range filter by using the `ALERT_TIME_RANGE` instead of `TIMESTAMP` cc @tonyghiani https://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov (cherry picked from commit 62827b1)
maryam-saeidi
added a commit
that referenced
this pull request
Apr 26, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [[AO] Fix time range filter in alerts table (#153648)](#153648) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-25T10:31:51Z","message":"[AO] Fix time range filter in alerts table (#153648)\n\nFixes #153284\r\n\r\n## Summary\r\n\r\nThis PR fixes the time range filter by using the `ALERT_TIME_RANGE`\r\ninstead of `TIMESTAMP`\r\ncc @tonyghiani \r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov","sha":"62827b1aabb7db6d5f8b7987b492c768169d291e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team: Actionable Observability","backport:prev-minor","v8.8.0"],"number":153648,"url":"https://github.com/elastic/kibana/pull/153648","mergeCommit":{"message":"[AO] Fix time range filter in alerts table (#153648)\n\nFixes #153284\r\n\r\n## Summary\r\n\r\nThis PR fixes the time range filter by using the `ALERT_TIME_RANGE`\r\ninstead of `TIMESTAMP`\r\ncc @tonyghiani \r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov","sha":"62827b1aabb7db6d5f8b7987b492c768169d291e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153648","number":153648,"mergeCommit":{"message":"[AO] Fix time range filter in alerts table (#153648)\n\nFixes #153284\r\n\r\n## Summary\r\n\r\nThis PR fixes the time range filter by using the `ALERT_TIME_RANGE`\r\ninstead of `TIMESTAMP`\r\ncc @tonyghiani \r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov","sha":"62827b1aabb7db6d5f8b7987b492c768169d291e"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153284
Summary
This PR fixes the time range filter by using the
ALERT_TIME_RANGEinstead ofTIMESTAMPcc @tonyghiani
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2039
Screen.Recording.2023-03-23.at.12.34.30.mov