Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] Fix time range filter in alerts table #153532

Closed

Conversation

maryam-saeidi
Copy link
Member

Summary

This PR fixes the time range filter by using the ALERT_TIME_RANGE instead of TIMESTAMP

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 23, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / ObservabilityAlertSearchBar should filter active alerts
  • [job] [logs] Jest Tests #4 / ObservabilityAlertSearchBar should include defaultSearchQueries in es query
  • [job] [logs] FTR Configs #39 / ObservabilityApp alert status filter can be filtered to only show "active" alerts using the filter button
  • [job] [logs] FTR Configs #39 / ObservabilityApp alert status filter can be filtered to only show "active" alerts using the filter button
  • [job] [logs] FTR Configs #39 / ObservabilityApp alert status filter can be filtered to only show "all" alerts using the filter button
  • [job] [logs] FTR Configs #39 / ObservabilityApp alert status filter can be filtered to only show "all" alerts using the filter button
  • [job] [logs] FTR Configs #39 / ObservabilityApp alert status filter can be filtered to only show "recovered" alerts using the filter button
  • [job] [logs] FTR Configs #39 / ObservabilityApp alert status filter can be filtered to only show "recovered" alerts using the filter button
  • [job] [logs] FTR Configs #39 / ObservabilityApp alert status filter is filtered to only show "all" alerts by default
  • [job] [logs] FTR Configs #39 / ObservabilityApp alert status filter is filtered to only show "all" alerts by default
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts / Add to case When user has all priviledges for cases opens a flyout when Add to new case is clicked
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts / Add to case When user has all priviledges for cases opens a flyout when Add to new case is clicked
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts / Add to case When user has all priviledges for cases opens a modal when Add to existing case is clicked
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts / Add to case When user has all priviledges for cases opens a modal when Add to existing case is clicked
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts / Add to case When user has all priviledges for cases renders case options in the overflow menu
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts / Add to case When user has all priviledges for cases renders case options in the overflow menu
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts / Add to case When user has read permissions for cases does not render case options in the overflow menu
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts / Add to case When user has read permissions for cases does not render case options in the overflow menu
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Actions Button Opens rule details page when click on "View Rule Details"
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Actions Button Opens rule details page when click on "View Rule Details"
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Filtering Applies filters correctly
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Filtering Applies filters correctly
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Flyout Can be closed
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Flyout Can be closed
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Flyout Can be opened
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Flyout Can be opened
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Flyout When open "after all" hook for "Displays a View rule details link"
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Flyout When open "after all" hook for "Displays a View rule details link"
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Flyout When open "before all" hook for "Displays the correct title"
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Flyout When open "before all" hook for "Displays the correct title"
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Renders the correct number of cells
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Renders the correct number of cells
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Renders the table
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts Alerts table Renders the table
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts pagination When 10 alerts are found Page size selector Default rows per page is 50
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts pagination When 10 alerts are found Page size selector Default rows per page is 50
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts pagination When 10 alerts are found Page size selector Renders page size selector
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts pagination When 10 alerts are found Page size selector Renders page size selector
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts pagination When 10 alerts are found Page size selector Shows up to 10 rows per page
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts pagination When 10 alerts are found Page size selector Shows up to 10 rows per page
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts pagination When 10 alerts are found Page size selector Shows up to 25 rows per page
  • [job] [logs] FTR Configs #39 / ObservabilityApp Observability alerts pagination When 10 alerts are found Page size selector Shows up to 25 rows per page

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB -2.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi
Copy link
Member Author

maryam-saeidi commented Mar 23, 2023

I will create another PR with the correct email for the commit.

Update: #153648

@maryam-saeidi maryam-saeidi deleted the 153284-fix-time-range-filter branch March 23, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants