Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Fix alert query time range filter #153284

Closed
maryam-saeidi opened this issue Mar 20, 2023 · 1 comment · Fixed by #153648
Closed

[AO] Fix alert query time range filter #153284

maryam-saeidi opened this issue Mar 20, 2023 · 1 comment · Fixed by #153648
Assignees
@maryam-saeidi
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@maryam-saeidi
Copy link
Member

📝 Summary

We need to change the time range query to compare it with the start and end time of an alert in order to avoid the following issue:

Screen.Recording.2023-03-20.at.10.21.36.mov

Hint

The related logic can be found here.

✅ Acceptance Criteria

  • Fix the time range filter when querying alert
@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Mar 20, 2023
@maryam-saeidi maryam-saeidi self-assigned this Mar 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

This was referenced Mar 20, 2023
Merged
Merged
maryam-saeidi added a commit that referenced this issue Mar 25, 2023
@maryam-saeidi
[AO] Fix time range filter in alerts table (#153648)
62827b1 
Fixes #153284

## Summary

This PR fixes the time range filter by using the `ALERT_TIME_RANGE`
instead of `TIMESTAMP`
cc @tonyghiani 



https://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov
maryam-saeidi added a commit to maryam-saeidi/kibana that referenced this issue Apr 25, 2023
@maryam-saeidi
[AO] Fix time range filter in alerts table (elastic#153648)
9150f90 
Fixes elastic#153284

## Summary

This PR fixes the time range filter by using the `ALERT_TIME_RANGE`
instead of `TIMESTAMP`
cc @tonyghiani

https://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov
(cherry picked from commit 62827b1)
maryam-saeidi added a commit that referenced this issue Apr 26, 2023
@maryam-saeidi
[8.7] [AO] Fix time range filter in alerts table (#153648) (#155739)
e7fd103 
# Backport

This will backport the following commits from `main` to `8.7`:
- [[AO] Fix time range filter in alerts table
(#153648)](#153648)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-25T10:31:51Z","message":"[AO]
Fix time range filter in alerts table (#153648)\n\nFixes
#153284\r\n\r\n## Summary\r\n\r\nThis PR fixes the time range filter by
using the `ALERT_TIME_RANGE`\r\ninstead of `TIMESTAMP`\r\ncc @tonyghiani
\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov","sha":"62827b1aabb7db6d5f8b7987b492c768169d291e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:
Actionable
Observability","backport:prev-minor","v8.8.0"],"number":153648,"url":"https://github.com/elastic/kibana/pull/153648","mergeCommit":{"message":"[AO]
Fix time range filter in alerts table (#153648)\n\nFixes
#153284\r\n\r\n## Summary\r\n\r\nThis PR fixes the time range filter by
using the `ALERT_TIME_RANGE`\r\ninstead of `TIMESTAMP`\r\ncc @tonyghiani
\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov","sha":"62827b1aabb7db6d5f8b7987b492c768169d291e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153648","number":153648,"mergeCommit":{"message":"[AO]
Fix time range filter in alerts table (#153648)\n\nFixes
#153284\r\n\r\n## Summary\r\n\r\nThis PR fixes the time range filter by
using the `ALERT_TIME_RANGE`\r\ninstead of `TIMESTAMP`\r\ncc @tonyghiani
\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/12370520/227532946-087c85c5-1390-47eb-bf0a-bd7319a000a7.mov","sha":"62827b1aabb7db6d5f8b7987b492c768169d291e"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AO] Fix time range filter in alerts table maryam-saeidi/kibana
2 participants
@maryam-saeidi @elasticmachine