[APM] Integrate Alert Search bar in alert tab #149610

kpatticha · 2023-01-26T16:42:01Z

Summary

Closes: #146290

Integrate Alert search bar
Delete alerts status filters as it comes for free with the search bar
Respect time range when fetching alert counts on service inventory and service overview page
- as the search bar now supports time ranges, it's required to display consistent data.

Before

After

Screen.Recording.2023-01-26.at.17.37.44.mov

TODO

getServiceAlerts query doesn't include environment while the table respects that filter. Check what's the correct way.

elasticmachine · 2023-01-26T16:42:08Z

Pinging @elastic/apm-ui (Team:APM)

x-pack/plugins/apm/server/routes/services/get_services/get_service_alerts.ts

…-fix'

cauemarcondes

LGTM, just a couple of suggestions.

cauemarcondes · 2023-01-26T18:05:32Z

x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx

+                push(history, {
+                  query: {
+                    rangeFrom,
+                  },
+                })
+              }


I think this will be better to visualize. WDYT?

Suggested change

push(history, {

query: {

rangeFrom,

},

})

}

push(history, { query: { rangeFrom, }, }) }

what do you mean "visualize" ?

I meant just to write it in a single line.

updated here 1e899e0

cauemarcondes · 2023-01-26T18:11:12Z

x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx

+              onRangeToChange={(rangeTo) =>
+                push(history, {
+                  query: {
+                    rangeTo,
+                  },
+                })
+              }


Can you do something like that? I haven't tested it and feel free to ignore it 😅

function pushToHistory(value: any) { push(history, { query: { [value]: value } }); }

Suggested change

onRangeToChange={(rangeTo) =>

push(history, {

query: {

rangeTo,

},

})

}

onRangeToChange={pushToHistory}

let me try it 😃

Ah, you'll probably do something like. Maybe not worth it.

function pushToHistory({key:string, value: any}) { push(history, { query: { [key]: value } }); }

cauemarcondes · 2023-01-26T18:14:05Z

x-pack/plugins/apm/common/environment_filter_values.ts

@@ -55,6 +55,18 @@ export function getEnvironmentEsField(environment: string) {
  return { [SERVICE_ENVIRONMENT]: environment };
 }

+export function getEnvironmentKuery(environment: string) {


Can't you use this function instead?

https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/common/environment_filter_values.ts#L46-L56

I could use it like this:

const environmentValue = getEnvironmentEsField(environment)?.[SERVICE_ENVIRONMENT] let query = `${SERVICE_NAME}:${serviceName}`; if (environmentKuery) { // HERE I need to use again `SERVICE_ENVIRONMENT` query += ` AND ${SERVICE_ENVIRONMENT}: ${environmentValue}`; }

so I thought it might be cleaner to have the function getEnvironmentKuery responsible for returning the kuery

…nd search bar

… into 146290-alert-search-bar

kibana-ci · 2023-01-27T15:00:29Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1368	1367	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.3MB	3.3MB	-150.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`apm`	32.2KB	32.2KB	+49.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv · 2023-01-27T19:46:17Z

x-pack/plugins/apm/common/environment_filter_values.ts

@@ -43,18 +44,30 @@ export const ENVIRONMENT_NOT_DEFINED = {
  label: getEnvironmentLabel(ENVIRONMENT_NOT_DEFINED_VALUE),
 };

-export function getEnvironmentEsField(environment: string) {
-  if (
+function isEnvironmentDefined(environment: string) {


@kpatticha Shouldn't this be called isEnvironmentUndefined?

ah! I fixed it and forgot to push 😢

thanks for catching this!, will fix it in a follow-up PR

## Summary this time I did make sure I pushed it 🐒 related to: #149610 (comment)

## Summary Closes: elastic#146290 - Integrate Alert search bar - Delete alerts status filters as it comes for free with the search bar - Respect time range when fetching alert counts on service inventory and service overview page - as the search bar now supports time ranges, it's required to display consistent data. ### Before ![image](https://user-images.githubusercontent.com/3369346/214894397-6850274f-f701-481a-a12c-688c144f4c32.png) ### After https://user-images.githubusercontent.com/3369346/214894788-5fcd42e2-b48f-434f-b38d-18579bfc280e.mov TODO - [x] [getServiceAlerts](https://github.com/elastic/kibana/pull/149610/files#diff-82ef341af674bd7f203551b4d75b73d221a49e6ae4169e0c396e96abb04902bcR59-R67 ) query doesn't include environment while the table respects that filter. Check what's the correct way. --------- Co-authored-by: kibanamachine <[email protected]>

## Summary this time I did make sure I pushed it 🐒 related to: elastic#149610 (comment)

kpatticha added 2 commits January 26, 2023 17:32

[APM] Integrate Alert search bar in alert tab

d2a6594

Filter alerts counts with timerage

ea7c2c5

kpatticha added enhancement New value added to drive a business result v8.7.0 labels Jan 26, 2023

kpatticha requested a review from a team as a code owner January 26, 2023 16:42

botelastic bot added the Team:APM All issues that need APM UI Team support label Jan 26, 2023

kpatticha commented Jan 26, 2023

View reviewed changes

x-pack/plugins/apm/server/routes/services/get_services/get_service_alerts.ts Show resolved Hide resolved

kpatticha added release_note:enhancement ci:cloud-deploy Create or update a Cloud deployment labels Jan 26, 2023

kpatticha and others added 3 commits January 26, 2023 18:03

Update translations

670f085

Fix API tests

2ff6cf6

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

ac5ce29

…-fix'

cauemarcondes approved these changes Jan 26, 2023

View reviewed changes

kpatticha added 6 commits January 27, 2023 10:14

Filter alert counts with enviroment

aac41ce

Escape environment value for kuery

4bf78b2

Update api tests

042aeb4

Replace unit test with e2e to cover the integration of alerts table a…

9b1027a

…nd search bar

Merge branch '146290-alert-search-bar' of github.com:kpatticha/kibana…

ce3b2ce

… into 146290-alert-search-bar

Address comments

1e899e0

kpatticha enabled auto-merge (squash) January 27, 2023 15:37

kpatticha merged commit 5476c93 into elastic:main Jan 27, 2023

kibanamachine added the backport:skip This commit does not require backporting label Jan 27, 2023

sorenlouv reviewed Jan 27, 2023

View reviewed changes

kpatticha mentioned this pull request Jan 27, 2023

[APM] Fix statement to match function name #149743

Merged

kpatticha added a commit that referenced this pull request Jan 28, 2023

[APM] Fix statement to match function name (#149743)

83293c9

## Summary this time I did make sure I pushed it 🐒 related to: #149610 (comment)

kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023

[APM] Fix statement to match function name (elastic#149743)

4746473

## Summary this time I did make sure I pushed it 🐒 related to: elastic#149610 (comment)

kpatticha mentioned this pull request Feb 21, 2023

[APM] Alert link in service inventory should link to the active alerts not all #151727

Closed

gbamparop mentioned this pull request Apr 27, 2023

[REQUEST]: Alerts tab in APM elastic/observability-docs#2887

Closed

maryam-saeidi mentioned this pull request Jun 30, 2023

[o11y alerting] Removing alerts group buttons #160529

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Integrate Alert Search bar in alert tab #149610

[APM] Integrate Alert Search bar in alert tab #149610

kpatticha commented Jan 26, 2023 •

edited

Loading

elasticmachine commented Jan 26, 2023

cauemarcondes left a comment

cauemarcondes Jan 26, 2023

kpatticha Jan 26, 2023

cauemarcondes Jan 26, 2023

kpatticha Jan 27, 2023

cauemarcondes Jan 26, 2023

kpatticha Jan 26, 2023

cauemarcondes Jan 26, 2023

cauemarcondes Jan 26, 2023

kpatticha Jan 27, 2023

kibana-ci commented Jan 27, 2023 •

edited

Loading

sorenlouv Jan 27, 2023

kpatticha Jan 27, 2023

[APM] Integrate Alert Search bar in alert tab #149610

[APM] Integrate Alert Search bar in alert tab #149610

Conversation

kpatticha commented Jan 26, 2023 • edited Loading

Summary

Before

After

elasticmachine commented Jan 26, 2023

cauemarcondes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibana-ci commented Jan 27, 2023 • edited Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kpatticha commented Jan 26, 2023 •

edited

Loading

kibana-ci commented Jan 27, 2023 •

edited

Loading