Address comments

elastic · Jan 27, 2023 · 1e899e0 · 1e899e0
1 parent ce3b2ce
commit 1e899e0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 19 deletions.
diff --git a/x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx b/x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx
@@ -74,26 +74,14 @@ export function AlertsOverview() {
             <ObservabilityAlertSearchBar
               appName={'apmApp'}
               kuery={kuery}
-              onRangeFromChange={(rangeFrom) =>
-                push(history, {
-                  query: {
-                    rangeFrom,
-                  },
-                })
+              onRangeFromChange={(value) =>
+                push(history, { query: { rangeFrom: value } })
               }
-              onRangeToChange={(rangeTo) =>
-                push(history, {
-                  query: {
-                    rangeTo,
-                  },
-                })
+              onRangeToChange={(value) =>
+                push(history, { query: { rangeTo: value } })
               }
-              onKueryChange={(kuery) =>
-                push(history, {
-                  query: {
-                    kuery,
-                  },
-                })
+              onKueryChange={(value) =>
+                push(history, { query: { kuery: value } })
               }
               defaultSearchQueries={apmQueries}
               onStatusChange={setAlertStatusFilter}

diff --git a/x-pack/plugins/apm/public/components/routing/templates/apm_service_template/index.tsx b/x-pack/plugins/apm/public/components/routing/templates/apm_service_template/index.tsx
@@ -234,7 +234,7 @@ function useTabs({ selectedTab }: { selectedTab: Tab['key'] }) {
         }
       );
     },
-    [serviceName, start, end]
+    [serviceName, start, end, environment]
   );
 
   const query = omit(
-Original file line number
+Diff line change
@@ Expand Up @@
             }
           );
         },
-        [serviceName, start, end]
+        [serviceName, start, end, environment]
       );
       const query = omit(
@@ Expand Down @@