Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Alert link in service inventory should link to the active alerts not all #151727

Closed
kpatticha opened this issue Feb 21, 2023 · 1 comment · Fixed by #152015
Closed

[APM] Alert link in service inventory should link to the active alerts not all #151727

kpatticha opened this issue Feb 21, 2023 · 1 comment · Fixed by #152015
Assignees
Labels

Comments

@kpatticha
Copy link
Contributor

Problem

In the service inventory, we display the total number of active alert for the service
Clicking on the alert count leads the user to the Alerts page. However, the alert page by default shows all the alerts (Recovered, Active).
I need one additional click to see the active alerts.

Screen.Recording.2023-02-21.at.16.41.27.mov

Proposal

  1. Pass the alert status in the query
    https://github.com/yngrdyn/kibana/blob/main/x-pack/plugins/apm/public/components/routing/templates/apm_service_template/index.tsx#L357-L374

  2. or display the active alerts by default on the alerts page

related
#146702
#149610

@kpatticha kpatticha added Team:APM All issues that need APM UI Team support apm:alerting apm:test-plan-regression v8.7.0 labels Feb 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@yngrdyn yngrdyn self-assigned this Feb 21, 2023
yngrdyn added a commit that referenced this issue Feb 24, 2023
…ected (#152015)

Closes #151727.

### Changes
- `alertStatus` added to `/services/{serviceName}/alerts` and
`/mobile-services/{serviceName}/alerts` route
- Set `AlertStatusFilter` depending on `alertStatus` param

#### Before 


https://user-images.githubusercontent.com/1313018/220971887-cffe51e7-bc48-4dc5-ad74-0677b81d9c2c.mov


#### After


https://user-images.githubusercontent.com/1313018/220971381-89f04363-a935-4462-babd-d10ae72d32e1.mov
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 24, 2023
…ected (elastic#152015)

Closes elastic#151727.

### Changes
- `alertStatus` added to `/services/{serviceName}/alerts` and
`/mobile-services/{serviceName}/alerts` route
- Set `AlertStatusFilter` depending on `alertStatus` param

#### Before

https://user-images.githubusercontent.com/1313018/220971887-cffe51e7-bc48-4dc5-ad74-0677b81d9c2c.mov

#### After

https://user-images.githubusercontent.com/1313018/220971381-89f04363-a935-4462-babd-d10ae72d32e1.mov
(cherry picked from commit a70de03)
kibanamachine referenced this issue Feb 24, 2023
…ab selected (#152015) (#152073)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[APM] Service inventory alert icon to Alerts page with Active tab
selected (#152015)](#152015)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yngrid
Coello","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-24T10:22:54Z","message":"[APM]
Service inventory alert icon to Alerts page with Active tab selected
(#152015)\n\nCloses
https://github.com/elastic/kibana/issues/151727.\r\n\r\n### Changes\r\n-
`alertStatus` added to `/services/{serviceName}/alerts`
and\r\n`/mobile-services/{serviceName}/alerts` route\r\n- Set
`AlertStatusFilter` depending on `alertStatus` param\r\n\r\n#### Before
\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1313018/220971887-cffe51e7-bc48-4dc5-ad74-0677b81d9c2c.mov\r\n\r\n\r\n####
After\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1313018/220971381-89f04363-a935-4462-babd-d10ae72d32e1.mov","sha":"a70de0387bf2b6b8e17c03c62702a0ed960de367","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","v8.7.0","v8.8.0"],"number":152015,"url":"https://github.com/elastic/kibana/pull/152015","mergeCommit":{"message":"[APM]
Service inventory alert icon to Alerts page with Active tab selected
(#152015)\n\nCloses
https://github.com/elastic/kibana/issues/151727.\r\n\r\n### Changes\r\n-
`alertStatus` added to `/services/{serviceName}/alerts`
and\r\n`/mobile-services/{serviceName}/alerts` route\r\n- Set
`AlertStatusFilter` depending on `alertStatus` param\r\n\r\n#### Before
\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1313018/220971887-cffe51e7-bc48-4dc5-ad74-0677b81d9c2c.mov\r\n\r\n\r\n####
After\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1313018/220971381-89f04363-a935-4462-babd-d10ae72d32e1.mov","sha":"a70de0387bf2b6b8e17c03c62702a0ed960de367"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152015","number":152015,"mergeCommit":{"message":"[APM]
Service inventory alert icon to Alerts page with Active tab selected
(#152015)\n\nCloses
https://github.com/elastic/kibana/issues/151727.\r\n\r\n### Changes\r\n-
`alertStatus` added to `/services/{serviceName}/alerts`
and\r\n`/mobile-services/{serviceName}/alerts` route\r\n- Set
`AlertStatusFilter` depending on `alertStatus` param\r\n\r\n#### Before
\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1313018/220971887-cffe51e7-bc48-4dc5-ad74-0677b81d9c2c.mov\r\n\r\n\r\n####
After\r\n\r\n\r\nhttps://user-images.githubusercontent.com/1313018/220971381-89f04363-a935-4462-babd-d10ae72d32e1.mov","sha":"a70de0387bf2b6b8e17c03c62702a0ed960de367"}}]}]
BACKPORT-->

Co-authored-by: Yngrid Coello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants