forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[APM] Integrate Alert Search bar in alert tab (elastic#149610)
## Summary Closes: elastic#146290 - Integrate Alert search bar - Delete alerts status filters as it comes for free with the search bar - Respect time range when fetching alert counts on service inventory and service overview page - as the search bar now supports time ranges, it's required to display consistent data. ### Before ![image](https://user-images.githubusercontent.com/3369346/214894397-6850274f-f701-481a-a12c-688c144f4c32.png) ### After https://user-images.githubusercontent.com/3369346/214894788-5fcd42e2-b48f-434f-b38d-18579bfc280e.mov TODO - [x] [getServiceAlerts](https://github.com/elastic/kibana/pull/149610/files#diff-82ef341af674bd7f203551b4d75b73d221a49e6ae4169e0c396e96abb04902bcR59-R67 ) query doesn't include environment while the table respects that filter. Check what's the correct way. --------- Co-authored-by: kibanamachine <[email protected]>
- Loading branch information
1 parent
fbd7f56
commit 94082f2
Showing
12 changed files
with
173 additions
and
307 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
x-pack/plugins/apm/ftr_e2e/cypress/e2e/read_only_user/service_overview/alerts_table.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import url from 'url'; | ||
import { synthtrace } from '../../../../synthtrace'; | ||
import { opbeans } from '../../../fixtures/synthtrace/opbeans'; | ||
|
||
const start = '2021-10-10T00:00:00.000Z'; | ||
const end = '2021-10-10T00:15:00.000Z'; | ||
|
||
const serviceOverviewHref = url.format({ | ||
pathname: '/app/apm/services/opbeans-java/alerts', | ||
query: { rangeFrom: start, rangeTo: end }, | ||
}); | ||
|
||
describe('Errors table', () => { | ||
before(() => { | ||
synthtrace.index( | ||
opbeans({ | ||
from: new Date(start).getTime(), | ||
to: new Date(end).getTime(), | ||
}) | ||
); | ||
}); | ||
|
||
after(() => { | ||
synthtrace.clean(); | ||
}); | ||
|
||
beforeEach(() => { | ||
cy.loginAsViewerUser(); | ||
}); | ||
|
||
it('Alerts table with the search bar is populated', () => { | ||
cy.visitKibana(serviceOverviewHref); | ||
cy.contains('opbeans-java'); | ||
cy.contains('All'); | ||
cy.contains('Active'); | ||
cy.contains('Recovered'); | ||
cy.getByTestSubj('globalQueryBar').should('exist'); | ||
}); | ||
}); |
73 changes: 0 additions & 73 deletions
73
x-pack/plugins/apm/public/components/app/alerts_overview/alerts_table_status_filter.tsx
This file was deleted.
Oops, something went wrong.
170 changes: 0 additions & 170 deletions
170
x-pack/plugins/apm/public/components/app/alerts_overview/index.test.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.