Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Update landing page for add fleet server #144179

Merged
merged 5 commits into from
Nov 3, 2022

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Oct 28, 2022

Summary

Follow up of #142894
Part of #137785

Updates the landing page for "Add fleet server":
Screenshot 2022-11-02 at 17 56 00

"Add fleet Server button" opens up the flyout:
Screenshot 2022-10-28 at 18 04 29

Also the "add fleet server" in settings section opens up the flyout:
Screenshot 2022-10-28 at 18 04 46

Checklist

@criamico criamico self-assigned this Oct 28, 2022
@criamico criamico added v8.6.0 Team:Fleet Team label for Observability Data Collection Fleet team release_note:skip Skip the PR/issue when compiling release notes labels Oct 28, 2022
@criamico
Copy link
Contributor Author

criamico commented Nov 2, 2022

@elasticmachine merge upstream

@criamico criamico marked this pull request as ready for review November 2, 2022 15:27
@criamico criamico requested a review from a team as a code owner November 2, 2022 15:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico
Copy link
Contributor Author

criamico commented Nov 2, 2022

@elasticmachine merge upstream

@nchaulet
Copy link
Member

nchaulet commented Nov 2, 2022

In the design looks like the landing page text has a max width maybe something we should keep here
Screen Shot 2022-11-02 at 12 19 10 PM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 855.9KB 858.0KB +2.1KB
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 103 108 +5
securitySolution 439 445 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 104 110 +6
securitySolution 516 522 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliaElastic
Copy link
Contributor

Is this change in scope? #144242 (comment)

@criamico
Copy link
Contributor Author

criamico commented Nov 3, 2022

Is this change in scope? #144242 (comment)

@juliaElastic we discussed with @nchaulet and we decided to go ahead with what we already have and do any further adjustment in separate PRs. We'll also have a review with the PM because some aspects of the flow are not clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants