Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Support per agent policy Fleet Server hosts #144242

Merged
merged 11 commits into from
Nov 2, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Oct 31, 2022

Summary

Related to #137785

That PR allow to override the Fleet server hosts for an agent policy.

To do so we are introducing the following changes:

  • the UI to create/edit an agent policy allow to select a Fleet server hosts
  • The enrollment Flyout retrieve the correct fleet server for the selected agent policy

UI Changes

Screen Shot 2022-11-01 at 9 39 06 AM

Screen Shot 2022-10-31 at 2 25 36 PM

Screen Shot 2022-10-31 at 2 24 41 PM

Screen Shot 2022-10-31 at 2 23 43 PM

@nchaulet nchaulet self-assigned this Oct 31, 2022
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0 labels Nov 1, 2022
@nchaulet nchaulet marked this pull request as ready for review November 1, 2022 13:42
@nchaulet nchaulet requested review from a team as code owners November 1, 2022 13:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic
Copy link
Contributor

Is it in scope to change the Fleet Server enrollment Advanced tab to pre-populate the existing Fleet Server host when we select an agent policy?

image

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM 🚀

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core changes lgtm (an integration_test check hash change)

@kpollich
Copy link
Member

kpollich commented Nov 2, 2022

Is it in scope to change the Fleet Server enrollment Advanced tab to pre-populate the existing Fleet Server host when we select an agent policy?

This should be covered by the redesign of this landing screen in @criamico's PR here: #144179

@nchaulet
Copy link
Member Author

nchaulet commented Nov 2, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 732 733 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 855.1KB 855.9KB +797.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 114.5KB 115.0KB +531.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
ingest-agent-policies 18 19 +1
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 64 +7
osquery 103 108 +5
securitySolution 439 445 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 72 +7
osquery 104 110 +6
securitySolution 516 522 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit cbaa32b into elastic:main Nov 2, 2022
@nchaulet nchaulet deleted the feature-per-policy-fleet-server-host branch November 2, 2022 15:22
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants